Skip to content

Conversation

@david-perez
Copy link
Contributor

This is the result of running ktlint from the repository root. We have
ktlint running on pre-commit and CI on changed files, but these
violations slipped through the cracks.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This is the result of running `ktlint` from the repository root. We have
`ktlint` running on pre-commit and CI on changed files, but these
violations slipped through the cracks.
@david-perez david-perez requested review from a team as code owners April 19, 2022 15:15
@david-perez
Copy link
Contributor Author

I'll submit a follow-up PR upgrading ktlint to the latest version.

@david-perez
Copy link
Contributor Author

I'll submit a follow-up PR upgrading ktlint to the latest version.

Provided we can upgrade Kotlin version to 1.6.20.

Copy link
Contributor

@crisidev crisidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -23.55% 53016.41 69345.7
Total requests -23.58% 4771772 6243836
Total errors NaN% 0 0
Total successes -23.58% 4771772 6243836
Average latency ms -37.62% 0.63 1.01
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -40.21% 16.55 27.68
Stdev latency ms -72.35% 0.47 1.7
Transfer Mb -23.58% 496.03 649.05
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

Copy link
Contributor

@Velfi Velfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@david-perez david-perez merged commit a870d2a into main Apr 19, 2022
@david-perez david-perez deleted the davidpz-run-`ktlint`-from-repository-root branch April 19, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants