fix(training): address issues with #208 #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
HCookie
previously approved these changes
Jul 11, 2025
HCookie
reviewed
Jul 11, 2025
| class VariableMaskingScalerSchema(BaseModel): | ||
| target_: Literal["anemoi.training.losses.scalers.VariableMaskingLossScaler"] = Field(..., alias="_target_") | ||
| variables: list[str] = Field(defaultexample=["tp"]) | ||
| "Variables to compute the loss over." |
Member
There was a problem hiding this comment.
Might be worth mentioning the invert here
OpheliaMiralles
previously approved these changes
Jul 11, 2025
Contributor
OpheliaMiralles
left a comment
OpheliaMiralles
left a comment
There was a problem hiding this comment.
Looks good to me!
HCookie
changed the title
HCookie
changed the title
Member
|
Integration tests and unit test now pass |
Member
Author
|
It looks ready to go! |
Merged
anaprietonem
pushed a commit
that referenced
this pull request
Jul 28, 2025
Add new schema for scaler, `VariableMaskingLossScaler`, introduced in #208 --------- Co-authored-by: Harrison Cook <[email protected]>
anaprietonem
pushed a commit
that referenced
this pull request
Aug 4, 2025
🤖 Automated Release PR This PR was created by `release-please` to prepare the next release. Once merged: 1. A new version tag will be created 2. A GitHub release will be published 3. The changelog will be updated Changes to be included in the next release: --- <details><summary>training: 0.6.0</summary> ## [0.6.0](training-0.5.1...training-0.6.0) (2025-08-01) ### ⚠ BREAKING CHANGES * for schemas of data processors ([#433](#433)) * BaseGraphModule and tasks introduced in anemoi-core ([#399](#399)) ### Features * Add metadata back to pl checkpoint. ([#303](#303)) ([0193b28](0193b28)) * BaseGraphModule and tasks introduced in anemoi-core ([#399](#399)) ([f8ab962](f8ab962)) * **deps:** Use mlflow-skinny instead of mlflow ([#418](#418)) ([6a8beb3](6a8beb3)) * Log FTT2 loss + Fourier Correlation loss ([#148](#148)) ([345b0ab](345b0ab)) * **model:** Postprocessors for leaky boundings ([#315](#315)) ([b54562b](b54562b)) * **models:** Checkpointed Mapper Chunking ([#406](#406)) ([8577772](8577772)) * **models:** Mapper edge sharding ([#366](#366)) ([326751d](326751d)) * Variable filtering ([#208](#208)) ([fba5e47](fba5e47)) ### Bug Fixes * Dropping 3.9 ([#436](#436)) ([f6c0214](f6c0214)) * For schemas of data processors ([#433](#433)) ([539939b](539939b)) * Mlflow hp params limit ([#424](#424)) ([138bc3a](138bc3a)) * Mlflowlogger duplicated key ([#414](#414)) ([cb64a1c](cb64a1c)) * **models,traininig:** Hierarchical model + integration test ([#400](#400)) ([71dfd89](71dfd89)) * **models:** Add removed sharded_input_key in PR400 ([#425](#425)) ([089fe6f](089fe6f)) * New checkpoint ([#445](#445)) ([a25df93](a25df93)) * Plotting error when precip related params are not diagnostic ([#369](#369)) ([010cfa3](010cfa3)) * **training:** Address issues with [#208](#208) ([#417](#417)) ([665f462](665f462)) * **training:** Scaler memory usage ([#391](#391)) ([a9d30e1](a9d30e1)) * Update import mflow utils unit tests ([#427](#427)) ([70ecdd9](70ecdd9)) * Update level retrieval logic ([#405](#405)) ([f393bc3](f393bc3)) * Use transforms: Variable for ExtractVariableGroupAndLevel ([#321](#321)) ([7649f4f](7649f4f)) * Warm restart ([#443](#443)) ([ff96236](ff96236)) ### Documentation * **graphs:** Documenting some missing features ([#423](#423)) ([8addbd8](8addbd8)) </details> <details><summary>graphs: 0.6.3</summary> ## [0.6.3](graphs-0.6.2...graphs-0.6.3) (2025-08-01) ### Features * **graphs:** Add lat weighted attribute ([#223](#223)) ([5dd32ca](5dd32ca)) * **graphs:** Support to export edges to npz ([#395](#395)) ([e21738f](e21738f)) ### Bug Fixes * Dropping 3.9 ([#436](#436)) ([f6c0214](f6c0214)) * **graphs:** Revert PR [#379](#379) ([#409](#409)) ([d51219f](d51219f)) * **graphs:** Throw error instead of raising warning when graph exists. ([#379](#379)) ([6ec6c18](6ec6c18)) * **graphs:** Undo masking when torch-cluster is installed ([#375](#375)) ([9f75c06](9f75c06)) ### Documentation * **graphs:** Documenting some missing features ([#423](#423)) ([8addbd8](8addbd8)) </details> <details><summary>models: 0.9.0</summary> ## [0.9.0](models-0.8.1...models-0.9.0) (2025-08-01) ### ⚠ BREAKING CHANGES * for schemas of data processors ([#433](#433)) ### Features * **model:** Postprocessors for leaky boundings ([#315](#315)) ([b54562b](b54562b)) * **models:** Checkpointed Mapper Chunking ([#406](#406)) ([8577772](8577772)) * **models:** Mapper edge sharding ([#366](#366)) ([326751d](326751d)) ### Bug Fixes * Dropping 3.9 ([#436](#436)) ([f6c0214](f6c0214)) * For schemas of data processors ([#433](#433)) ([539939b](539939b)) * **models,traininig:** Hierarchical model + integration test ([#400](#400)) ([71dfd89](71dfd89)) * **models:** Remove repeated lines ([#377](#377)) ([1f0b861](1f0b861)) * **models:** Uneven channel sharding ([#385](#385)) ([dd095c4](dd095c4)) * Pydantic model validator not working in transformer schema ([#422](#422)) ([42f437a](42f437a)) * Remove dead code and fix typo ([#357](#357)) ([8c615ba](8c615ba)) </details> --- > [!IMPORTANT] > Please do not change the PR title, manifest file, or any other automatically generated content in this PR unless you understand the implications. Changes here can break the release process. > >⚠️ Merging this PR will: > - Create a new release > - Trigger deployment pipelines > - Update package versions **Before merging:** - Ensure all tests pass - Review the changelog carefully - Get required approvals [Release-please documentation](https://github.com/googleapis/release-please)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new schema for scaler,
VariableMaskingLossScaler, introduced in #208What problem does this change solve?
What issue or task does this change relate to?
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.