Skip to content

feat(graphs): add lat weighted attribute #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jul 17, 2025
Merged

feat(graphs): add lat weighted attribute #223

merged 26 commits into from
Jul 17, 2025

Conversation

@JPXKQX
Copy link
Member

@JPXKQX JPXKQX commented Apr 2, 2025 •
edited
Loading

Description

This PR introduces several node attributes for rectilinear grids in Anemoi, addressing issues such as those outlined in Issue #146 .

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I have added tests that prove my fix is effective or that my feature works
  • I ran the complete Pytest test suite locally, and they pass
  • I have tested the changes on a single GPU
  • I have tested the changes on multiple GPUs / multi-node setups
  • I have run the Benchmark Profiler against the old version of the code
  • If the new feature introduces modifications at the config level, I have made sure to update Pydantic Schemas and default configs accordingly

Dependencies

  • I have ensured that the code is still pip-installable after the changes and runs
  • I have tested that new dependencies themselves are pip-installable.
  • I have not introduced new dependencies in the inference portion of the pipeline

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

@JPXKQX JPXKQX self-assigned this Apr 2, 2025
@github-project-automation github-project-automation bot moved this to Now In Progress in Anemoi-dev Apr 2, 2025
@github-actions github-actions bot added the graphs label Apr 2, 2025
@JPXKQX JPXKQX marked this pull request as ready for review April 8, 2025 12:33
@JPXKQX JPXKQX mentioned this pull request Apr 8, 2025
Closed
@JPXKQX JPXKQX moved this from Now In Progress to Under Review in Anemoi-dev Apr 14, 2025
@mchantry mchantry added the ATS Approval Not Needed No approval needed by ATS label Apr 16, 2025
mchantry
mchantry reviewed May 1, 2025
View reviewed changes
mchantry
mchantry reviewed May 1, 2025
View reviewed changes
mchantry
mchantry reviewed May 1, 2025
View reviewed changes
@veech veech mentioned this pull request May 9, 2025
Closed
@JPXKQX JPXKQX requested a review from mchantry May 14, 2025 12:53
This was linked to issues May 14, 2025
First use of anemoi-training -- ValueError: Duplicate generators present. #146
Closed
Unable to use UniformWeights config option for area_weights #312
Closed
mchantry
mchantry previously approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@mchantry mchantry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@mchantry mchantry moved this from Under Review to For merging in Anemoi-dev Jun 4, 2025
@JPXKQX JPXKQX requested a review from mchantry June 4, 2025 09:41
mchantry
mchantry approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@mchantry mchantry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution.

@JPXKQX JPXKQX merged commit 5dd32ca into main Jul 17, 2025
18 checks passed
@JPXKQX JPXKQX deleted the feature/lat-weighted-attr branch July 17, 2025 08:06
@github-project-automation github-project-automation bot moved this from For merging to Done in Anemoi-dev Jul 17, 2025
@DeployDuck DeployDuck mentioned this pull request Jul 17, 2025
Merged
anaprietonem pushed a commit that referenced this pull request Jul 28, 2025
@JPXKQX @mchantry @anaprietonem
feat(graphs): add lat weighted attribute (#223)
ed795f3 
## Description

This PR introduces several node attributes for rectilinear grids in
Anemoi, addressing issues such as those outlined in Issue #146 .

## Type of Change

-   [ ] Bug fix (non-breaking change which fixes an issue)
-   [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
-   [ ] Documentation update

## Issue Number

<!-- Link the Issue number this change addresses, ideally in one of the
"magic format" such as Closes #XYZ -->

<!-- Alternatively, explain the motivation behind the changes and the
context in which they are being made. -->

## Code Compatibility

-   [x] I have performed a self-review of my code

### Code Performance and Testing

- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I ran the [complete Pytest
test](https://anemoi.readthedocs.io/projects/training/en/latest/dev/testing.html)
suite locally, and they pass
-   [ ] I have tested the changes on a single GPU
-   [ ] I have tested the changes on multiple GPUs / multi-node setups
- [ ] I have run the Benchmark Profiler against the old version of the
code
- [ ] If the new feature introduces modifications at the config level, I
have made sure to update Pydantic Schemas and default configs
accordingly


<!-- In case this affects the model sharding or other specific
components please describe these here. -->

### Dependencies

- [ ] I have ensured that the code is still pip-installable after the
changes and runs
- [ ] I have tested that new dependencies themselves are
pip-installable.
- [x] I have not introduced new dependencies in the inference portion of
the pipeline

<!-- List any new dependencies that are required for this change and the
justification to add them. -->

### Documentation

-   [x] My code follows the style guidelines of this project
- [ ] I have updated the documentation and docstrings to reflect the
changes
- [x] I have added comments to my code, particularly in
hard-to-understand areas

<!-- Describe any major updates to the documentation -->

## Additional Notes

<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

---------

Co-authored-by: Matthew Chantry <[email protected]>
anaprietonem pushed a commit that referenced this pull request Aug 4, 2025
@DeployDuck
chore: Release main (#380)
9e7f90d 
🤖 Automated Release PR

This PR was created by `release-please` to prepare the next release.
Once merged:

1. A new version tag will be created
2. A GitHub release will be published
3. The changelog will be updated

Changes to be included in the next release:
---


<details><summary>training: 0.6.0</summary>

##
[0.6.0](training-0.5.1...training-0.6.0)
(2025-08-01)


### ⚠ BREAKING CHANGES

* for schemas of data processors
([#433](#433))
* BaseGraphModule and tasks introduced in anemoi-core
([#399](#399))

### Features

* Add metadata back to pl checkpoint.
([#303](#303))
([0193b28](0193b28))
* BaseGraphModule and tasks introduced in anemoi-core
([#399](#399))
([f8ab962](f8ab962))
* **deps:** Use mlflow-skinny instead of mlflow
([#418](#418))
([6a8beb3](6a8beb3))
* Log FTT2 loss + Fourier Correlation loss
([#148](#148))
([345b0ab](345b0ab))
* **model:** Postprocessors for leaky boundings
([#315](#315))
([b54562b](b54562b))
* **models:** Checkpointed Mapper Chunking
([#406](#406))
([8577772](8577772))
* **models:** Mapper edge sharding
([#366](#366))
([326751d](326751d))
* Variable filtering
([#208](#208))
([fba5e47](fba5e47))


### Bug Fixes

* Dropping 3.9 ([#436](#436))
([f6c0214](f6c0214))
* For schemas of data processors
([#433](#433))
([539939b](539939b))
* Mlflow hp params limit
([#424](#424))
([138bc3a](138bc3a))
* Mlflowlogger duplicated key
([#414](#414))
([cb64a1c](cb64a1c))
* **models,traininig:** Hierarchical model + integration test
([#400](#400))
([71dfd89](71dfd89))
* **models:** Add removed sharded_input_key in PR400
([#425](#425))
([089fe6f](089fe6f))
* New checkpoint
([#445](#445))
([a25df93](a25df93))
* Plotting error when precip related params are not diagnostic
([#369](#369))
([010cfa3](010cfa3))
* **training:** Address issues with
[#208](#208)
([#417](#417))
([665f462](665f462))
* **training:** Scaler memory usage
([#391](#391))
([a9d30e1](a9d30e1))
* Update import mflow utils unit tests
([#427](#427))
([70ecdd9](70ecdd9))
* Update level retrieval logic
([#405](#405))
([f393bc3](f393bc3))
* Use transforms: Variable for ExtractVariableGroupAndLevel
([#321](#321))
([7649f4f](7649f4f))
* Warm restart ([#443](#443))
([ff96236](ff96236))


### Documentation

* **graphs:** Documenting some missing features
([#423](#423))
([8addbd8](8addbd8))
</details>

<details><summary>graphs: 0.6.3</summary>

##
[0.6.3](graphs-0.6.2...graphs-0.6.3)
(2025-08-01)


### Features

* **graphs:** Add lat weighted attribute
([#223](#223))
([5dd32ca](5dd32ca))
* **graphs:** Support to export edges to npz
([#395](#395))
([e21738f](e21738f))


### Bug Fixes

* Dropping 3.9 ([#436](#436))
([f6c0214](f6c0214))
* **graphs:** Revert PR
[#379](#379)
([#409](#409))
([d51219f](d51219f))
* **graphs:** Throw error instead of raising warning when graph exists.
([#379](#379))
([6ec6c18](6ec6c18))
* **graphs:** Undo masking when torch-cluster is installed
([#375](#375))
([9f75c06](9f75c06))


### Documentation

* **graphs:** Documenting some missing features
([#423](#423))
([8addbd8](8addbd8))
</details>

<details><summary>models: 0.9.0</summary>

##
[0.9.0](models-0.8.1...models-0.9.0)
(2025-08-01)


### ⚠ BREAKING CHANGES

* for schemas of data processors
([#433](#433))

### Features

* **model:** Postprocessors for leaky boundings
([#315](#315))
([b54562b](b54562b))
* **models:** Checkpointed Mapper Chunking
([#406](#406))
([8577772](8577772))
* **models:** Mapper edge sharding
([#366](#366))
([326751d](326751d))


### Bug Fixes

* Dropping 3.9 ([#436](#436))
([f6c0214](f6c0214))
* For schemas of data processors
([#433](#433))
([539939b](539939b))
* **models,traininig:** Hierarchical model + integration test
([#400](#400))
([71dfd89](71dfd89))
* **models:** Remove repeated lines
([#377](#377))
([1f0b861](1f0b861))
* **models:** Uneven channel sharding
([#385](#385))
([dd095c4](dd095c4))
* Pydantic model validator not working in transformer schema
([#422](#422))
([42f437a](42f437a))
* Remove dead code and fix typo
([#357](#357))
([8c615ba](8c615ba))
</details>

---
> [!IMPORTANT]
> Please do not change the PR title, manifest file, or any other
automatically generated content in this PR unless you understand the
implications. Changes here can break the release process.
> 
> ⚠️ Merging this PR will:
> - Create a new release
> - Trigger deployment pipelines
> - Update package versions

 **Before merging:**
 - Ensure all tests pass
 - Review the changelog carefully
 - Get required approvals

[Release-please
documentation](https://github.com/googleapis/release-please)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchantry mchantry mchantry approved these changes

Assignees

@JPXKQX JPXKQX

Labels

ATS Approval Not Needed No approval needed by ATS graphs training

Projects

Anemoi-dev
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to use UniformWeights config option for area_weights First use of anemoi-training -- ValueError: Duplicate generators present.

3 participants

@JPXKQX @mchantry