-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Read dotnet.config file to use MTP or VSTest in dotnet test #46717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Evangelink
merged 4 commits into
main
from
dev/mabdullah/use-config-file-for-dotnet-test
Feb 12, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5ceefa2
Add logic to use mtp or vstest in dotnet
mariam-abdulla d09a56e
Add dotnet.config to test projects of tests
mariam-abdulla 6d6168f
Merge branch 'main' into dev/mabdullah/use-config-file-for-dotnet-test
Evangelink dd191b5
Merge branch 'main' into dev/mabdullah/use-config-file-for-dotnet-test
mariam-abdulla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/HybridTestRunnerTestProjects/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/MSTestMetaPackageProjectWithMultipleTFMsSolution/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/MultiTestProjectSolutionWithDifferentFailures/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/MultiTestProjectSolutionWithDiscoveredTests/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/MultiTestProjectSolutionWithTests/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/MultipleTestProjectSolution/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/MultipleTestProjectsWithoutSolution/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/ProjectSolutionForMultipleTFMs/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/TestProjectSolution/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/TestProjectSolutionWithCodeCoverage/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/TestProjectSolutionWithTestsAndArtifacts/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/TestProjectWithClassLibrary/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/TestProjectWithDiscoveredTests/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/TestProjectWithMultipleTFMsSolution/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/TestProjectWithTests/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [dotnet.test:runner] | ||
| name= "MicrosoftTestingPlatform" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Windows, should this disallow reading
dotnet.configfrom the root directory of a volume, like #33216 and #33282 disallow reading.config\dotnet-tools.jsonfrom there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose such a restriction is not necessary for security because the volume root directory on Windows typically has an
NT AUTHORITY\Authenticated Users:(AD)access control entry. This ACE allows the user to create a subdirectory such as.configin the root directory, and the user can then get full control on the new subdirectory and create adotnet-tools.jsonfile in there. However, the ACE does not allow the user to create a file such asdotnet.configorglobal.jsondirectly in the root directory. See FILE_ADD_SUBDIRECTORY in File Access Rights Constants.