Do not look in root for .config\dotnet-tools.json manifest for windows
#33282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When use this command in Windows system, The process will search for tool information in the .config\dotnet-tools.json file from the bottom up and download it. For Windows, the program does not check the root folder for the tool manifest if the Environment Variable `CHECK_MANIFEST_IN_ROOT" is not set. For Linux/MacOS, the program checks the root folder for the tool manifest.
ghost
added
GrabYourPitchforks
approved these changes
Jun 21, 2023
Member
GrabYourPitchforks
left a comment
GrabYourPitchforks
left a comment
There was a problem hiding this comment.
Looks like a straightforward port of the approved 7.0 change.
Member
|
Marc told me offline that this change already came in via an automated PR #33290. That would explain the conflicts you're seeing. |
Member
|
Post-merge resolution looks like the only change left in this PR is white space so I think we're good to close it as that confirms the codeflow in 33290 brought in the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting branch 8.0.0
When use this command in Windows system. The process will search for tool information in the .config\dotnet-tools.json file from the bottom up and download it.
For Windows, the program does not check the root folder for the tool manifest if the Environment Variable `CHECK_MANIFEST_IN_ROOT" is not set.
For Linux/MacOS, the program checks the root folder for the tool manifest.