[release/6.0] Ignore non-X509 certificates in SignedCms #67462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for AttributeCertificateV1/AttributeCertificateV2/OtherCertificate entries in the SignedCms without causing a decode error. That data is not presented to callers via the SignedCms object, but the behavior is consistent with SignedCms on .NET Framework and its underlying WinCryptMsg counterpart.
bartonjs
added
Servicing-consider
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsThis is a backport of #64348 at the request of NuGet (cc @dtivel). Customer Impact.NET fails to understand RFC 3161 timestamps from Microsoft timestamping services, including Azure Code Signing timestamping. There is a risk that signed NuGet packages would fail to verify with such a timestamp. TestingAutomated test included with the PR. RiskLow risk. This fix has been in dotnet/runtime:main for over 2 months.
|
leecow
added
Servicing-approved
carlossanlop
approved these changes
Apr 13, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #64348 at the request of NuGet (cc @dtivel).
Customer Impact
.NET fails to understand RFC 3161 timestamps from Microsoft timestamping services, including Azure Code Signing timestamping. There is a risk that signed NuGet packages would fail to verify with such a timestamp.
Testing
Automated test included with the PR.
Risk
Low risk. This fix has been in dotnet/runtime:main for over 2 months.