Ignore non-X509 certificates in SignedCms #64348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-System.Security
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsPartial cherry-pick of the work @bartonjs started and added a test. The test uses
|
Member
Author
|
Draft because I want to see how Windows handles this in CI first. |
Member
Author
|
Looks like everything "passed" on Windows, and then infrastructure failed to report results. " END OF WORK ITEM LOG: Command timed out, and was killed]". |
bartonjs
reviewed
Jan 28, 2022
src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/SignedDocuments.cs
Show resolved
Hide resolved
bartonjs
approved these changes
Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial cherry-pick of the work @bartonjs started and added a test.
The test uses
SignedCmsand notRfc3161TimestampTokensince the example TST that reproduces the issue has other, unrelated issued with being a valid TST.Contributes to #62307.