Skip to content

Mark UrlDecodeInternal noinline to work around inliner limitation #118599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Mark UrlDecodeInternal noinline to work around inliner limitation #118599

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cd7713
Mark UrlDecodeInternal noinline to work around inliner limitation
AndyAyersMS Aug 11, 2025
1a5e668
Update src/libraries/System.Private.CoreLib/src/System/Net/WebUtility.cs
AndyAyersMS Aug 11, 2025
f9900f8
Update src/libraries/System.Private.CoreLib/src/System/Net/WebUtility.cs
AndyAyersMS Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/Net/WebUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,12 @@ private static int IndexOfHtmlEncodingChar(ReadOnlySpan<char> input)

#region UrlDecode implementation

// Marking UrlDecodeInternal noinline to work around
// a jit issue where inlining this method may cause
// key inlinees to not be inlined
//
[return: NotNullIfNotNull(nameof(value))]
[MethodImpl(MethodImplOptions.NoInlining)]
private static string? UrlDecodeInternal(string? value, Encoding encoding)
{
if (string.IsNullOrEmpty(value))
Expand Down Expand Up @@ -506,7 +511,12 @@ private static int IndexOfHtmlEncodingChar(ReadOnlySpan<char> input)
return helper.GetString();
}

// Marking UrlDecodeInternal noinline to work around
// a jit issue where inlining this method may cause
// key inlinees to not be inlined
//
[return: NotNullIfNotNull(nameof(bytes))]
[MethodImpl(MethodImplOptions.NoInlining)]
private static byte[]? UrlDecodeInternal(byte[]? bytes, int offset, int count)
{
if (!ValidateUrlEncodingParameters(bytes, offset, count))
Expand Down
Loading