Mark UrlDecodeInternal noinline to work around inliner limitation #118599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this method is inlined, the JIT may be unable to inline some of its callees, leading to a perf regression. See dotnet#114996.
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a JIT compiler inlining limitation by marking two UrlDecodeInternal methods with [MethodImpl(MethodImplOptions.NoInlining)] to prevent performance regressions. The issue occurs when these methods are inlined, causing the JIT to fail to inline their important callees.
Key changes:
- Added
NoInliningattribute to bothUrlDecodeInternalmethod overloads - Added explanatory comments describing the JIT workaround
src/libraries/System.Private.CoreLib/src/System/Net/WebUtility.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Net/WebUtility.cs
Outdated
Show resolved
Hide resolved
|
In particular #114996 (comment) @jeffhandley @tannergooding PTAL |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
tannergooding
approved these changes
Aug 11, 2025
|
@EgorBot --arm --intel --filter |
|
Egorbot not seeing any improvement here... back to the drawing board. |
This was referenced Aug 11, 2025
|
Handling this via budget increase instead: #118641 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this method is inlined, the JIT may be unable to inline some of its callees, leading to a perf regression.
See #114996.