[release/9.0] Backport "Fix SVE ExtendWidening ConditionalSelect tests" (#107601) #107725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
amanasifkhalid
added
area-CodeGen-coreclr
Contributor
Author
|
#107722 needs to be merged in first. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
4 tasks
Contributor
Author
|
@kunalspathak PTAL, thanks! |
kunalspathak
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Sep 12, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can take this as tell mode (test only)
jeffschwMSFT
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107601to release/9.0
/cc @kunalspathak @SwapnilGaikwad
Customer Impact
The test template logic for
*ExtendWideningSVE intrinsics was not calling the correct helper method to verify the intrinsic's return value for an enabled vector lane underConditionalSelectscenarios. Furthermore, for vector lanes disabled by the mask passed toConditionalSelect, the test logic was not comparing the element to the expected true/false value. This PR fixes both issues.Regression
This was introduced by #107207, which was fixing an actual JIT bug, and added this new test logic to improve coverage.
Testing
With this fix, all of our SVE tests are now passing.
Risk
Low. This fix is only to ensure CI is clean on
release/9.0.