Skip to content

During source build, target net8.0 only #8779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2023
Merged

During source build, target net8.0 only #8779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions eng/SourceBuildPrebuiltBaseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
<UsageData>
<IgnorePatterns>
<UsagePattern IdentityGlob="Microsoft.SourceBuild.Intermediate.*/*" />

<!-- Ignoring the following prebuilts. net7.0 targeting is still needed
due to https://github.com/dotnet/razor/issues/8293#issuecomment-1454042002
net7.0 targeting removal is tracked in https://github.com/dotnet/razor/issues/8531 -->
<UsagePattern IdentityGlob="Microsoft.AspNetCore.App.Ref/7.0.2" />
<UsagePattern IdentityGlob="Microsoft.NETCore.App.Ref/7.0.2" />
</IgnorePatterns>
</UsageData>
1 change: 1 addition & 0 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
<DefaultNetFxTargetFramework>net472</DefaultNetFxTargetFramework>
<DefaultNetCoreTargetFramework>net8.0</DefaultNetCoreTargetFramework>
<DefaultNetCoreTargetFrameworks>$(DefaultNetCoreTargetFramework);net7.0</DefaultNetCoreTargetFrameworks>
<DefaultNetCoreTargetFrameworks Condition="'$(DotNetBuildFromSource)' == 'true'">$(DefaultNetCoreTargetFramework)</DefaultNetCoreTargetFrameworks>
Copy link
Member

@jaredpar jaredpar Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this going to break when it merges into dotnet/sdk for 7.0 releases? Basically doesn't this have the exact same problem roslyn had that forced us to multi-target net7.0;net8.0 when '$(DotNetBuildFromSourceFlavor)' != 'Product'?

Copy link
Member Author

@MichaelSimons MichaelSimons Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I overlooked that this flows into multiple releases. Thanks for the catch. I will open another PR.

<DefaultNetCoreWindowsTargetFrameworks>net8.0-windows;net7.0-windows</DefaultNetCoreWindowsTargetFrameworks>
</PropertyGroup>
<!--
Expand Down