During source build, target net8.0 only #8779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Jun 1, 2023
Member
Author
|
@davidwengier - The CI failure doesn't appear related to these changes. I see it in other legs as well. If agreed, can you please merge? TIA. |
jaredpar
reviewed
Jun 2, 2023
| <DefaultNetFxTargetFramework>net472</DefaultNetFxTargetFramework> | ||
| <DefaultNetCoreTargetFramework>net8.0</DefaultNetCoreTargetFramework> | ||
| <DefaultNetCoreTargetFrameworks>$(DefaultNetCoreTargetFramework);net7.0</DefaultNetCoreTargetFrameworks> | ||
| <DefaultNetCoreTargetFrameworks Condition="'$(DotNetBuildFromSource)' == 'true'">$(DefaultNetCoreTargetFramework)</DefaultNetCoreTargetFrameworks> |
Member
There was a problem hiding this comment.
Isn't this going to break when it merges into dotnet/sdk for 7.0 releases? Basically doesn't this have the exact same problem roslyn had that forced us to multi-target net7.0;net8.0 when '$(DotNetBuildFromSourceFlavor)' != 'Product'?
Member
Author
There was a problem hiding this comment.
Yes, I overlooked that this flows into multiple releases. Thanks for the catch. I will open another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8293
For .NET source-build, repos must target NetCurrent (.NET 8.0) and/or NetStandard. This initial changes for #8293 added .NET 8.0 on top of the existing tfms. This PR conditions source-build to only target net8.0 in order to eliminate prebuilts.