Skip to content

Do not display exception on graceful exit case #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2019
Merged

Do not display exception on graceful exit case #300

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d29966
Do not display exception on graceful exit case
sywhang Jun 2, 2019
8a8b464
Use Debug.WriteLine instead of removing
sywhang Jun 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Tools/dotnet-counters/CounterMonitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,8 @@ private async Task<int> StartMonitor()
source.Dynamic.All += Dynamic_All;
source.Process();
}
catch (Exception ex)
Copy link

@jorive jorive Jun 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can keep the exception information, but using Debug.WriteLine instead? What do you think?

catch
{
Console.Error.WriteLine($"[ERROR] {ex.ToString()}");
}
finally
{
Expand Down