Do not display exception on graceful exit case #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorive
reviewed
Jun 2, 2019
| source.Dynamic.All += Dynamic_All; | ||
| source.Process(); | ||
| } | ||
| catch (Exception ex) |
There was a problem hiding this comment.
Maybe we can keep the exception information, but using Debug.WriteLine instead? What do you think?
jorive
approved these changes
Jun 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #298.
This was added mainly for debugging purposes during development but an end user might think of it as a crash rather than a graceful exit even though it's supposed to be a graceful exit case.