Wait for dashboard to be healthy before returning URL via RPC. #9027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Apr 30, 2025
davidfowl
deleted the
mitchdenny/devcontainer-dashboard-portforwarding-bug
branch
mitchdenny
added a commit
that referenced
this pull request
Apr 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8412
Fixes: #8366
Before we shipped 9.2 I modified some of the logic around getting the dashboard URL to show in the CLI. It resulted in us no longer waiting for the dashboard to start before showing the URL.
This resulted in two issues. The first was that we displayed the URL to the dashboard before the port forwarding configuration was written in devcontainer/codespace scenarios. Because of this the one-time URL display detection that VSCode does never triggered port-forwarding on the dashboard (it would work the second time around).
The second issue was that we displayed the URL before the dashboard was running so if someone was quick enough (within a second or two) they could click on the dashboard URL and get an error which would leave them wondering whether something was broken.
This change makes the GetDashboardUrlsAsync method wait to get the URLs until after the dashboard is healthy which is after the port forwarding config is written.
This solves both issues listed above.