Update coverage filters #1811
Merged
Update coverage filters #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safern
reviewed
Jan 16, 2019
|
|
||
| <!-- Full coverage report. --> | ||
| <Import Condition="'$(EnableFullCoverageReportTarget)' == 'true' AND '$(Coverage)' == 'true' AND '$(SkipTests)' != 'true'" Project="$([MSBuild]::NormalizePath('$(TestCoreDir)', 'coverage', 'CoverageReport.targets'))" /> | ||
| <Import Condition="'$(EnableFullCoverageReportTarget)' == 'true' AND '$(SkipCoverageReport)' != 'true' AND '$(Coverage)' == 'true' AND '$(SkipTests)' != 'true'" Project="$([MSBuild]::NormalizePath('$(TestCoreDir)', 'coverage', 'CoverageReport.targets'))" /> |
Member
There was a problem hiding this comment.
From looking at these set of conditions it seems that there are a lot of conditions that can cause this to not be imported. Just to understand, SkipCoverageReport == true, but SkipTests==false, will cause to run code coverage and not to create a report? I just want to clarify what is the purpose of this property. Because we can also disable that with Coverage == false.
Member
Author
There was a problem hiding this comment.
Please ignore SkipTests which will be removed with #1704
safern
reviewed
Jan 16, 2019
src/Microsoft.DotNet.CoreFxTesting/build/core/coverage/Coverage.props
Outdated
Show resolved
Hide resolved
safern
reviewed
Jan 16, 2019
src/Microsoft.DotNet.CoreFxTesting/build/core/coverage/Coverage.targets
Outdated
Show resolved
Hide resolved
safern
reviewed
Jan 16, 2019
safern
reviewed
Jan 16, 2019
src/Microsoft.DotNet.CoreFxTesting/build/core/coverage/Coverage.targets
Outdated
Show resolved
Hide resolved
safern
reviewed
Jan 16, 2019
src/Microsoft.DotNet.CoreFxTesting/build/core/coverage/Coverage.targets
Outdated
Show resolved
Hide resolved
safern
reviewed
Jan 16, 2019
safern
reviewed
Jan 16, 2019
src/Microsoft.DotNet.CoreFxTesting/build/core/coverage/Coverage.targets
Outdated
Show resolved
Hide resolved
ViktorHofer
force-pushed
the
CoreLib
branch
2 times, most recently
from
14077b9 to
731fa0c
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows more coverage filters, i.e. better exclude filters. Prepares for Corelib support. Also adds a SkipCoverageReport option to disable on CI.