Add common arcade test targets #1704
Conversation
|
So with this change if I want to generate helix archives from a build script i.e for CI or official builds, I have to do |
|
I don't have a strong opinion on that. The reason why chose this is that ArchiveTests handles the ArchiveTests target and GenerateTestScripts handles the GenerateRunScript target. I think it's a good idea to bundle it together :) |
|
LOL actually I just saw that |
|
So then GenerateTestScript target will be hooked together by the dependent targets 😄 that is a nicer approach. |
|
@safern ready to merge? |
ViktorHofer
force-pushed
the
TestTargets
branch
from
bb7295b to
6fd6013
Compare
|
@safern @ercistj PTAL. I think this is now ready to be merged. |
|
|
||
| <Target Name="GenerateRunScript" | ||
| Inputs="unused" | ||
| Outputs="$(RunScriptOutputPath)" |
There was a problem hiding this comment.
Why inputs outputs if you don't use them for incremental nor batching?
There was a problem hiding this comment.
GenerateRunScript is part of the incremental build, at least that's what I believed.
There was a problem hiding this comment.
I meant that if you have no inputs and only outputs I would expect that target to always run.
| still generates the test execution script and archives the test dir for Helix consumption. | ||
| --> | ||
| <Target Name="RunTests" | ||
| Condition="'$(SkipTests)' != 'true' OR '$(TestDisabled)' == 'true'" |
There was a problem hiding this comment.
Interesting that this was inverted before. No-one was using it?
There was a problem hiding this comment.
Yeah I freaked out when I saw that condition 🤐
There was a problem hiding this comment.
No idea, but will follow-up on that one.
3 participants
Relates to dotnet/corefx#34385
Changes:
/p:ArchiveTests=Tests|IntegrationTests|PerformanceTests|(Packages)|All.$(SkipTests)property which is not needed anymore as the test targets should only be used if you REALLY want to run tests.$(Performance)property which is not needed anymore as performance tests now have a unique target and performance related msbuild files are only imported if `IsPerformanceTestProject´ equals true./t:Test,/t:IntegrationTestand/t:PerformanceTest. These are the common arcade targets that are expected to be present in the respective test project type.