[Xamarin.Android.Build.Tasks] Handle IOException in Aapt2Daemon #8130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Jun 16, 2023
jonpryor
reviewed
Jun 16, 2023
When cancelling a build on the command line we occasionally see the following exception. ``` Unhandled exception. System.IO.IOException: Broken pipe ---> System.Net.Sockets.SocketException (32): Broken pipe at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer) --- End of inner exception stack trace --- at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer) at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder) at System.IO.StreamWriter.WriteLine(String value) at Xamarin.Android.Tasks.Aapt2Daemon.Aapt2DaemonStart() at System.Threading.Thread.StartHelper.Callback(Object state) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) --- End of stack trace from previous location --- at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) Unhandled exception. System.IO.IOException: Broken pipe ---> System.Net.Sockets.SocketException (32): Broken pipe at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer) --- End of inner exception stack trace --- at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer) at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder) at System.IO.StreamWriter.WriteLine(String value) at Xamarin.Android.Tasks.Aapt2Daemon.Aapt2DaemonStart() at System.Threading.Thread.StartHelper.Callback(Object state) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) --- End of stack trace from previous location --- at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) Unhandled exception. System.IO.IOException: Broken pipe ---> System.Net.Sockets.SocketException (32): Broken pipe at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer) --- End of inner exception stack trace --- at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer) at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder) at System.IO.StreamWriter.WriteLine(String value) at Xamarin.Android.Tasks.Aapt2Daemon.Aapt2DaemonStart() at System.Threading.Thread.StartHelper.Callback(Object state) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) --- End of stack trace from previous location --- at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) ``` This happens because we are calling `Stream.WriteLine` after the process has already exited. So lets catch this exception and ignore it.
Contributor
Author
|
Test failures are the usual network failures 😠 |
jonathanpeppers
approved these changes
Jun 22, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jun 23, 2023
* main: Bump to google/bundletool@f17ce94a (dotnet#8135) [Xamarin.Android.Build.Tasks] Handle IOException in Aapt2Daemon (dotnet#8130) [tests] don't set `/uses-sdk@android:targetSdkVersion=34` by default (dotnet#8138)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jun 26, 2023
* main: Bump to google/bundletool@f17ce94a (dotnet#8135) [Xamarin.Android.Build.Tasks] Handle IOException in Aapt2Daemon (dotnet#8130) [tests] don't set `/uses-sdk@android:targetSdkVersion=34` by default (dotnet#8138)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cancelling a build on the command line we occasionally see the following exception.
This happens because we are calling
Stream.WriteLineafter the process has already exited. So lets catch this exception and ignore it.