[Xamarin.Android.Build.Tasks] Handle IOException in Aapt2Daemon (#8130)

* [Xamarin.Android.Build.Tasks] Handle IOException in Aapt2Daemon

When cancelling a build on the command line we occasionally
see the following exception.

```
Unhandled exception. System.IO.IOException: Broken pipe
 ---> System.Net.Sockets.SocketException (32): Broken pipe
   at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer)
   --- End of inner exception stack trace ---
   at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer)
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.IO.StreamWriter.WriteLine(String value)
   at Xamarin.Android.Tasks.Aapt2Daemon.Aapt2DaemonStart()
   at System.Threading.Thread.StartHelper.Callback(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
Unhandled exception. System.IO.IOException: Broken pipe
 ---> System.Net.Sockets.SocketException (32): Broken pipe
   at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer)
   --- End of inner exception stack trace ---
   at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer)
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.IO.StreamWriter.WriteLine(String value)
   at Xamarin.Android.Tasks.Aapt2Daemon.Aapt2DaemonStart()
   at System.Threading.Thread.StartHelper.Callback(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
Unhandled exception. System.IO.IOException: Broken pipe
 ---> System.Net.Sockets.SocketException (32): Broken pipe
   at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer)
   --- End of inner exception stack trace ---
   at System.IO.Pipes.PipeStream.WriteCore(ReadOnlySpan`1 buffer)
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.IO.StreamWriter.WriteLine(String value)
   at Xamarin.Android.Tasks.Aapt2Daemon.Aapt2DaemonStart()
   at System.Threading.Thread.StartHelper.Callback(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
```

This happens because we are calling `Stream.WriteLine` after the process
has already exited. So lets catch this exception and ignore it.


* use nameof

* Add additional try/catch

Author: dellis1972

src/Xamarin.Android.Build.Tasks/Tasks/Aapt2.cs

@@ -84,7 +84,7 @@ public override bool Execute ()
 				DaemonMaxInstanceCount = maxInstances;
 			else
 				DaemonMaxInstanceCount = Math.Min (DaemonMaxInstanceCount, maxInstances);
-			daemon  = Aapt2Daemon.GetInstance (BuildEngine4, GenerateFullPathToTool (),
+			daemon  = Aapt2Daemon.GetInstance (BuildEngine4, LogDebugMessage, GenerateFullPathToTool (),
 				DaemonMaxInstanceCount, GetRequiredDaemonInstances (), registerInDomain: DaemonKeepInDomain);
 			return base.Execute ();
 		}

src/Xamarin.Android.Build.Tasks/Utilities/Aapt2Daemon.cs

@@ -19,13 +19,13 @@ internal class Aapt2Daemon : IDisposable
 
 		internal static object RegisterTaskObjectKey => TypeFullName;
 
-		public static Aapt2Daemon GetInstance (IBuildEngine4 engine, string aapt2, int numberOfInstances, int initalNumberOfDaemons, bool registerInDomain = false)
+		public static Aapt2Daemon GetInstance (IBuildEngine4 engine, Action<string> log, string aapt2, int numberOfInstances, int initalNumberOfDaemons, bool registerInDomain = false)
 		{
 			var area = registerInDomain ? RegisteredTaskObjectLifetime.AppDomain : RegisteredTaskObjectLifetime.Build;
 			var daemon = engine.GetRegisteredTaskObjectAssemblyLocal<Aapt2Daemon> (RegisterTaskObjectKey, area);
 			if (daemon == null)
 			{
-				daemon = new Aapt2Daemon (aapt2, numberOfInstances, initalNumberOfDaemons);
+				daemon = new Aapt2Daemon (aapt2, numberOfInstances, initalNumberOfDaemons, log);
 				engine.RegisterTaskObjectAssemblyLocal (RegisterTaskObjectKey, daemon, area, allowEarlyCollection: false);
 			}
 			return daemon;
@@ -66,6 +66,7 @@ public void Complete (bool result)
 		long jobsRunning = 0;
 		long jobId = 0;
 		int maxInstances = 0;
+		Action<string> logger = null;
 
 		public CancellationToken Token => tcs.Token;
 
@@ -86,10 +87,11 @@ public bool JobsRunning
 
 		public int CurrentInstances => daemons.Count;
 
-		public Aapt2Daemon (string aapt2, int maxNumberOfInstances, int initalNumberOfDaemons)
+		public Aapt2Daemon (string aapt2, int maxNumberOfInstances, int initalNumberOfDaemons, Action<string> log)
 		{
 			Aapt2 = aapt2;
 			maxInstances = maxNumberOfInstances;
+			logger = log;
 			for (int i = 0; i < initalNumberOfDaemons; i++) {
 				SpawnAapt2Daemon ();
 			}
@@ -271,9 +273,19 @@ private void Aapt2DaemonStart ()
 			{
 				// Ignore this error. It occurs when the Task is cancelled.
 			}
-			aapt2.StandardInput.WriteLine ("quit");
-			aapt2.StandardInput.WriteLine ();
-			aapt2.WaitForExit ((int)TimeSpan.FromSeconds (5).TotalMilliseconds);
+			try {
+				aapt2.StandardInput.WriteLine ("quit");
+				aapt2.StandardInput.WriteLine ();
+				aapt2.WaitForExit ((int)TimeSpan.FromSeconds (5).TotalMilliseconds);
+			} catch (IOException) {
+				// Ignore this error. It occurs when the Build it cancelled.
+				try {
+					logger?.Invoke ($"{nameof (Aapt2Daemon)}: Ignoring IOException. Build was cancelled.");
+				} catch  {
+					// The Logger might not exist if the daemon exits after the logger has been
+					// collected.
+				}
+			}
 		}
 
 		bool IsAapt2Warning (string singleLine)