-
Notifications
You must be signed in to change notification settings - Fork 6
fix: migrate away from deprecated bitnami image #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: dropping support for postgres 13 BREAKING CHANGE: switching to official postgres image with alpine base
|
Since this is a breaking change, I wonder on how and when we should merge this and how we communicate this to reduce suprises by consumers. |
|
At least, we should add a note in README. What could happen in the worst case? If someone still uses version 13, they would get the old image, I suppose? How could someone rely on the bitnami base (e.g. extending our image with more packages), they would get errors and hopefully would read the README file at first. Nice idea to use official PostgreSQL images as the base. Why did we use bitnami in the first place? |
|
Yeah, worst case it breaks Dockerfiles of people that use our image at the base or breaks deployments where people rely on Env Variables of the bitnami image. Good question, because we used bitnami in our project and it seemed like a good choice, I guess. |
|
I have added a note in the README. I think we should go forward and merge this, since the 28th of August is getting closer. Can you review the readme and merge the PR if you think it is understandable @jschirrmacher. |
Breaking change details in dbsystel/postgresql-partman-container#32
Breaking change details in dbsystel/postgresql-partman-container#32
- This was broken after the postgresql-partman update: dbsystel/postgresql-partman-container#32 - Also needed to specify proper env variables
- This was broken after the postgresql-partman update: dbsystel/postgresql-partman-container#32 - Also needed to specify proper env variables Co-authored-by: TAMARA LIPOWSKI <[email protected]>
BREAKING CHANGE: dropping support for postgres 13
BREAKING CHANGE: switching to official postgres image with alpine base
relates to #31