Skip to content

Conversation

@Morl99
Copy link
Contributor

@Morl99 Morl99 commented Jul 29, 2025

BREAKING CHANGE: dropping support for postgres 13
BREAKING CHANGE: switching to official postgres image with alpine base

relates to #31

BREAKING CHANGE: dropping support for postgres 13
BREAKING CHANGE: switching to official postgres image with alpine base
@Morl99
Copy link
Contributor Author

Morl99 commented Jul 29, 2025

Since this is a breaking change, I wonder on how and when we should merge this and how we communicate this to reduce suprises by consumers.

@jschirrmacher
Copy link
Contributor

At least, we should add a note in README.

What could happen in the worst case? If someone still uses version 13, they would get the old image, I suppose? How could someone rely on the bitnami base (e.g. extending our image with more packages), they would get errors and hopefully would read the README file at first.

Nice idea to use official PostgreSQL images as the base. Why did we use bitnami in the first place?

@Morl99
Copy link
Contributor Author

Morl99 commented Jul 30, 2025

Yeah, worst case it breaks Dockerfiles of people that use our image at the base or breaks deployments where people rely on Env Variables of the bitnami image.

Good question, because we used bitnami in our project and it seemed like a good choice, I guess.

@Morl99
Copy link
Contributor Author

Morl99 commented Aug 19, 2025

I have added a note in the README. I think we should go forward and merge this, since the 28th of August is getting closer.

Can you review the readme and merge the PR if you think it is understandable @jschirrmacher.

@Morl99 Morl99 changed the title draft: fix: migrate away from deprecated bitnami image fix: migrate away from deprecated bitnami image Aug 19, 2025
@jschirrmacher jschirrmacher marked this pull request as ready for review August 19, 2025 06:09
@jschirrmacher jschirrmacher self-requested a review as a code owner August 19, 2025 06:09
@jschirrmacher jschirrmacher merged commit c8dd516 into main Aug 19, 2025
8 checks passed
@jschirrmacher jschirrmacher deleted the 31-switch-base-image branch August 19, 2025 06:12
zizou0x added a commit to propeller-heads/tycho-indexer that referenced this pull request Aug 19, 2025
zizou0x added a commit to propeller-heads/tycho-indexer that referenced this pull request Aug 19, 2025
tamaralipows pushed a commit to propeller-heads/tycho-protocol-sdk that referenced this pull request Aug 29, 2025
- This was broken after the postgresql-partman update: dbsystel/postgresql-partman-container#32
- Also needed to specify proper env variables
tamaralipows added a commit to propeller-heads/tycho-protocol-sdk that referenced this pull request Aug 29, 2025
- This was broken after the postgresql-partman update: dbsystel/postgresql-partman-container#32
- Also needed to specify proper env variables

Co-authored-by: TAMARA LIPOWSKI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants