This repository was archived by the owner on Jan 14, 2025. It is now read-only.
Initial parser port. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/packagemap.dart
Outdated
|
Needless to say backing out path normalization is not a long term fix. We could change our SDK version constraint obviously but then that would make the library less client-friendly. Anyway, something to consider. |
|
@sethladd PTAL? |
|
I think it's OK to require 1.11 for this package. Otherwise, LGTM |
I opened dart-lang/tools#1501 to keep track of this. In the short term I think making it play nice with |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 9, 2024
…al_port Initial parser port.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial port of Lasse's parser implementation.
@lrhn , @hterkelsen : PTAL!
FYI: @sethladd.