-
Notifications
You must be signed in to change notification settings - Fork 40
Add release notes for 4.4.4 #2056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughDocumentation updates for release 4.4.4: bumped version/last-updated metadata, added a new 4.4.4 release notes document, updated the release notes index to include it, adjusted support matrix entry, and modified acknowledgements (added @eslint/compat, removed @types/uuid). No code or control-flow changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
source/release-notes/4-4-4.rst (1)
16-22: Clarify dependency coordinates (optional).
Consider adding the Maven coordinate for precision.- - Netty (netty-codec-http) to version 4.1.125.Final + - Netty (io.netty:netty-codec-http) updated to 4.1.125.Finalsource/index.rst (1)
74-74: Latest version text updated correctly.
Consider adding a link to the downloads page next to it (optional).-The latest version of CrafterCMS is **version 4.4.4**. +The latest version of CrafterCMS is **version 4.4.4** (`Download <https://craftercms.com/download>`__).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
source/conf.py(1 hunks)source/contribute/acknowledgements.rst(3 hunks)source/index.rst(2 hunks)source/release-notes/4-4-4.rst(1 hunks)source/release-notes/index.rst(2 hunks)source/support.rst(2 hunks)
🔇 Additional comments (10)
source/support.rst (2)
2-2: Metadata bump looks good.
Last-updated updated to 4.4.4 is consistent with the PR intent.
28-28: Release date matches in docs; no internal downloads page found
- source/support.rst:28 — 4.4.4 (September 6, 2025)
- source/release-notes/4-4-4.rst:7 — Released September 6, 2025
- No downloads-related .rst files found under source/ — confirm external downloads page if applicable.
source/contribute/acknowledgements.rst (2)
2-2: Metadata bump acknowledged.
Last-updated -> 4.4.4 is fine.
311-312: Good addition: @eslint/compat.
Entry and link formatting match surrounding items and ordering.source/conf.py (1)
32-32: Verify javadoc for release 4.4.4 is published Unable to access https://javadoc.craftercms.org/4.4.4/ (HTTP 403). Confirm the 4.4.4 docs are available or update the javadoc_base_url extlink accordingly.source/release-notes/4-4-4.rst (2)
7-8: Release date matches support page; LGTM.
No action needed if consistent elsewhere.
23-23: Resolved: label compatibility-with-3.1.x found
The reference target is defined in source/release-notes/4-x-breaking-changes.rst (line 255), so no further action is needed.source/release-notes/index.rst (2)
2-2: Metadata bump OK.
14-14: New include correctly ordered (newest first).source/index.rst (1)
2-2: Metadata bump OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/release-notes/4-4-4.rst (2)
9-15: Upgrade guidance is present; consider linking to a specific section.Optionally link to precise anchors within the breaking changes/upgrade guides to reduce scrolling.
-Please see :ref:`Breaking changes <breaking-changes-4-x>` ... -For instructions ... :ref:`upgrading-craftercms` +Please see :ref:`Breaking changes <breaking-changes-4-x>` ... +For instructions ... :ref:`upgrading-craftercms#upgrade-from-4-4-x`
16-22: Call out the rationale for Netty bump.If the Netty update addresses CVEs or regressions, add a brief note and reference to the Netty release notes/CVE for transparency.
- - Netty (netty-codec-http) to version 4.1.126.Final + - Netty (netty-codec-http) to version 4.1.126.Final — includes fixes for [brief reason/CVE], see Netty release notes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
source/conf.py(1 hunks)source/contribute/acknowledgements.rst(2 hunks)source/index.rst(2 hunks)source/release-notes/4-4-4.rst(1 hunks)source/release-notes/index.rst(2 hunks)source/support.rst(2 hunks)
🔇 Additional comments (12)
source/conf.py (1)
32-32: Javadoc links confirmed for 4.4.4. Both engine and studio docs return HTTP 200.source/support.rst (2)
2-2: Metadata updated.
:last-updated:correctly reflects 4.4.4.
28-28: Verify external release tag and published date
The remote repository contains no4.4.4orv4.4.4tag nor a matching GitHub release; please confirm the release has been published and that the date “September 6, 2025” is correct.source/contribute/acknowledgements.rst (2)
2-2: Metadata updated.
:last-updated:bumped to 4.4.4 — ok.
311-312: ```shell
#!/bin/bashSearch all workspace package.json files for @eslint/compat
grep -R '"@eslint/compat"' -n --exclude-dir=node_modules .
Ensure @types/uuid has been removed from package.json
grep -R '"@types/uuid"' -n --exclude-dir=node_modules .
Verify that the runtime 'uuid' dependency is still present
grep -R '"uuid"' -n --exclude-dir=node_modules .
</blockquote></details> <details> <summary>source/release-notes/4-4-4.rst (3)</summary><blockquote> `1-2`: **Index directive now references 4.4.4.** Corrected version in the index — good catch. --- `3-8`: **Title and release date look consistent across docs.** Header and “Released September 6, 2025” align with support/index pages. --- `23-23`: **3.1.x cross-reference present.** Good to keep legacy upgrade path linked. </blockquote></details> <details> <summary>source/index.rst (2)</summary><blockquote> `2-2`: **Metadata updated.** `:last-updated:` set to 4.4.4 — ok. --- `74-74`: **Latest release link updated.** Points to 4.4.4 download page; good. </blockquote></details> <details> <summary>source/release-notes/index.rst (2)</summary><blockquote> `2-2`: **Metadata updated.** `:last-updated:` bumped to 4.4.4 — ok. --- `14-14`: **Release notes index includes 4-4-4 in correct order.** Placement before 4-4-3 maintains reverse-chronological ordering. </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Ticket reference or full description of what's in the PR
Add release notes for 4.4.4