-
Notifications
You must be signed in to change notification settings - Fork 40
Update date in support and breaking changes #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/release-notes/4-4-3.rst (1)
51-53: Clarify scope of SDK 5.x requirement to avoid ambiguityThis note sits under “Studio UI” but reads as product-wide. Suggest scoping it to Studio UI & Experience Builder and pointing out other packages remain ^4.3.0 (per the compatibility table).
- CrafterCMS version 4.4.3 works with JavaScript SDK version 5.0.0 and later as mentioned in :ref:`breaking-changes-in-craftercms-4-4-3`. - See :ref:`compatibility-with-craftercms-version` for more information. + Studio UI and Experience Builder in CrafterCMS 4.4.3 require JavaScript SDK version 5.0.0 and later (see :ref:`breaking-changes-in-craftercms-4-4-3`). + See :ref:`compatibility-with-craftercms-version` for package-by-package details; other SDK packages remain compatible at ^4.3.0.source/release-notes/4-x-breaking-changes.rst (1)
26-33: Good addition; tighten wording to reflect per-package compatibilityTo align with the compatibility table, specify which packages require 5.x and which remain at ^4.3.0.
-CrafterCMS version 4.4.3 works with JavaScript SDK version 5.0.0 and later. See :ref:`compatibility-with-craftercms-version` -for more information. +CrafterCMS 4.4.3 requires JavaScript SDK 5.0.0+ for Studio UI and Experience Builder; other SDK packages remain compatible at ^4.3.0. +See :ref:`compatibility-with-craftercms-version` for details.Also consider updating the document header’s
:last-updated:from4.4.0to4.4.3for accuracy.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
source/reference/api/javascript-sdk.rst(3 hunks)source/release-notes/4-4-3.rst(1 hunks)source/release-notes/4-x-breaking-changes.rst(1 hunks)source/support.rst(1 hunks)
🔇 Additional comments (3)
source/support.rst (1)
28-28: LGTM: latest version/date updated correctlyMatches release notes for September 4, 2025. Consider verifying this date is consistent with the downloads page and any marketing pages.
source/reference/api/javascript-sdk.rst (2)
2-2: Meta updated to 4.4.3 — looks good
36-41: Compatibility section and 4.4.3 row look consistentAnchors resolve from release notes; table values align with the narrative (EB/Studio UI ^5.0.0, others ^4.3.0).
Please double-check NPM publish ranges and that caret constraints reflect the intended minimal versions at release time.
Also applies to: 59-69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.4.4
|
Support page to be updated in the 4.4.4 release notes PR #2056 |
Ticket reference or full description of what's in the PR
Update date in support and breaking changes