Guard instrumentation exclude Interlocked #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 89.06% 89.08% +0.01%
==========================================
Files 16 16
Lines 1912 1915 +3
==========================================
+ Hits 1703 1706 +3
Misses 209 209
Continue to review full report at Codecov.
|
sharwell
approved these changes
Jan 16, 2019
Contributor
Author
tonerdo
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluding
System.Threading.Interlockedfrom instrumentation which is used for recording hits. Not excluding that type would cause an infinite loop as it would call itself.cc @sharwell @tonerdo