Skip to content

Trim cortex get and add descriptive logging around request handlers #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2019
Merged

Trim cortex get and add descriptive logging around request handlers #240

merged 5 commits into from
Jul 19, 2019

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Jul 19, 2019 •
edited by deliahu
Loading

Closes #207 #177

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

deliahu
deliahu reviewed Jul 19, 2019
View reviewed changes
cli/cmd/get.go Outdated

modelInput, err := getModelInput(urls.Join(apiEndpoint, "signature"))
if err != nil {
return "", errors.Wrap(err, "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to silently error here, since this might happen - right now I think "ready" is a little bit of a misnomer since the pod might be ready, but the server might not be running yet (although I haven't confirmed that yet, it's on my todo list)

@deliahu deliahu merged commit d35c413 into master Jul 19, 2019
@deliahu deliahu deleted the numpy-enabled-json-encoding branch July 19, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

@ospillinger ospillinger Awaiting requested review from ospillinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve logging around request handlers
2 participants
@vishalbollu @deliahu