-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat: rules and MCP fixes and UI updates #8053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…allin/con-4022-hide-empty-prompts-resources
…allin/con-4022-hide-empty-prompts-resources
…allin/con-4022-hide-empty-prompts-resources
…allin/con-4022-hide-empty-prompts-resources
|
|
✅ Review Complete Likely cause: Expired CONTINUE_API_KEY or missing continuedev/review-bot assistant 📋 View workflow logs for details. |
|
reopening #8018 here because of odd failing tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 issues found across 62 files
Prompt for AI agents (all 6 issues)
Understand the root cause of the following 6 issues and fix them.
<file name="gui/src/components/mainInput/Lump/useEditBlock.ts">
<violation number="1" location="gui/src/components/mainInput/Lump/useEditBlock.ts:28">
This condition dereferences `selectedProfile.fullSlug` without guarding it, so profiles lacking `fullSlug` will crash the hook at runtime. Please add optional chaining (or another null check) before accessing `ownerSlug` and `packageSlug`.</violation>
</file>
<file name="core/context/providers/RulesContextProvider.ts">
<violation number="1" location="core/context/providers/RulesContextProvider.ts:25">
Using sourceFile as the primary ID collapses multiple rules from the same file into one submenu item. Please keep slug as the first fallback so each rule remains selectable.</violation>
</file>
<file name="gui/src/pages/config/components/ToolPoliciesGroup.tsx">
<violation number="1" location="gui/src/pages/config/components/ToolPoliciesGroup.tsx:34">
The memo that filters tools depends on groupName but the dependency array omits it, so switching this component to another group will leave it showing the previous group's tools. Please add groupName to the dependency array to keep the memoized list in sync.</violation>
</file>
<file name="core/config/profile/doLoadConfig.ts">
<violation number="1" location="core/config/profile/doLoadConfig.ts:175">
`newConfig.slashCommands` can be undefined when the user config has no slash commands, so pushing to it here will throw. Guard with the same `??=` initialization used elsewhere before pushing.</violation>
</file>
<file name="core/context/mcp/MCPManagerSingleton.ts">
<violation number="1" location="core/context/mcp/MCPManagerSingleton.ts:30">
Disabling a server calls `conn.disconnect(true)` even when no transport has been set, so `this.transport.close()` throws if the user disables before the first successful connect. Please guard against this scenario before invoking `disconnect(true)`.</violation>
</file>
<file name="packages/config-yaml/src/markdown/markdownToRule.ts">
<violation number="1" location="packages/config-yaml/src/markdown/markdownToRule.ts:74">
If relativeDir is undefined you now return the frontmatter globs untouched, but existing callers (e.g. markdownToRule(content, id) in load/unroll.ts) do not pass the new relativePathForGlobs. For file rules without explicit globs this used to default to `<rule-dir>/**/*`; now it yields undefined so the rule never matches any files.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
ruleFileandpromptFiletosourceFilefor uniformity through the codebasedisabledstatusAlso deprecates gemini 1.5 models since they are no longer hosted on v1beta
e.g. https://github.com/continuedev/continue/actions/runs/18170217636/job/51722755412?pr=8053
Summary by cubic
Hide MCP Prompts and Resources in the Config > Tools view when none exist to reduce clutter and keep Tools as the focus. Aligns with CON-4022.