Skip to content

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Oct 1, 2025

Description

  • New Tools section UI moves tool policies for an MCP server into the MCP server Tools section
  • Hides settings Tools section resources and prompts if none are present, reduce confusion since Tools is the most common usage
  • Changes ruleFile and promptFile to sourceFile for uniformity through the codebase
  • Simplifies MCP disconnect logic to use a disabled status
  • Fixes edit block opening wrong thing for mcp servers, rules, and prompts in various situations and unifies logic
  • Fixes inaccurate parts of the init prompt
  • Fixes navigation to settings pages from fatal error
  • Fixes toggle switch click propagation
  • Fixes various bad tailwind classname merging
  • Removes unused Prompts section (was merged into rules)

Also deprecates gemini 1.5 models since they are no longer hosted on v1beta
e.g. https://github.com/continuedev/continue/actions/runs/18170217636/job/51722755412?pr=8053


Summary by cubic

Hide MCP Prompts and Resources in the Config > Tools view when none exist to reduce clutter and keep Tools as the focus. Aligns with CON-4022.

  • New Features
    • Render Prompts only when server.prompts.length > 0.
    • Render Resources only when server.resources.length > 0 or server.resourceTemplates.length > 0.

@RomneyDa RomneyDa requested a review from a team as a code owner October 1, 2025 17:22
@RomneyDa RomneyDa requested review from tingwai and removed request for a team October 1, 2025 17:22
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

⚠️ PR Title Format

Your PR title doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend using this format for better project organization.

Expected Format:

<type>[optional scope]: <description>

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

✅ Review Complete

⚠️ AI review completed but no review output was generated.

Likely cause: Expired CONTINUE_API_KEY or missing continuedev/review-bot assistant

📋 View workflow logs for details.


@RomneyDa
Copy link
Collaborator Author

RomneyDa commented Oct 1, 2025

reopening #8018 here because of odd failing tests

@RomneyDa RomneyDa changed the title Dallin/mcp UI updates and fixes feat: rules and MCP fixes and UI updates Oct 1, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 issues found across 62 files

Prompt for AI agents (all 6 issues)

Understand the root cause of the following 6 issues and fix them.


<file name="gui/src/components/mainInput/Lump/useEditBlock.ts">

<violation number="1" location="gui/src/components/mainInput/Lump/useEditBlock.ts:28">
This condition dereferences `selectedProfile.fullSlug` without guarding it, so profiles lacking `fullSlug` will crash the hook at runtime. Please add optional chaining (or another null check) before accessing `ownerSlug` and `packageSlug`.</violation>
</file>

<file name="core/context/providers/RulesContextProvider.ts">

<violation number="1" location="core/context/providers/RulesContextProvider.ts:25">
Using sourceFile as the primary ID collapses multiple rules from the same file into one submenu item. Please keep slug as the first fallback so each rule remains selectable.</violation>
</file>

<file name="gui/src/pages/config/components/ToolPoliciesGroup.tsx">

<violation number="1" location="gui/src/pages/config/components/ToolPoliciesGroup.tsx:34">
The memo that filters tools depends on groupName but the dependency array omits it, so switching this component to another group will leave it showing the previous group&#39;s tools. Please add groupName to the dependency array to keep the memoized list in sync.</violation>
</file>

<file name="core/config/profile/doLoadConfig.ts">

<violation number="1" location="core/config/profile/doLoadConfig.ts:175">
`newConfig.slashCommands` can be undefined when the user config has no slash commands, so pushing to it here will throw. Guard with the same `??=` initialization used elsewhere before pushing.</violation>
</file>

<file name="core/context/mcp/MCPManagerSingleton.ts">

<violation number="1" location="core/context/mcp/MCPManagerSingleton.ts:30">
Disabling a server calls `conn.disconnect(true)` even when no transport has been set, so `this.transport.close()` throws if the user disables before the first successful connect. Please guard against this scenario before invoking `disconnect(true)`.</violation>
</file>

<file name="packages/config-yaml/src/markdown/markdownToRule.ts">

<violation number="1" location="packages/config-yaml/src/markdown/markdownToRule.ts:74">
If relativeDir is undefined you now return the frontmatter globs untouched, but existing callers (e.g. markdownToRule(content, id) in load/unroll.ts) do not pass the new relativePathForGlobs. For file rules without explicit globs this used to default to `&lt;rule-dir&gt;/**/*`; now it yields undefined so the rule never matches any files.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 1, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 1, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 1, 2025
@RomneyDa RomneyDa merged commit a57eb80 into main Oct 1, 2025
67 of 69 checks passed
@RomneyDa RomneyDa deleted the dallin/mcp-ui-updates-and-fixes branch October 1, 2025 19:00
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 1, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2025
@github-actions github-actions bot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Oct 1, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 1, 2025

🎉 This PR is included in version 1.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 1, 2025

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files. tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants