Skip to content

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Sep 29, 2025

Description

  • New Tools section UI moves tool policies for an MCP server into the MCP server Tools section
  • Hides settings Tools section resources and prompts if none are present, reduce confusion since Tools is the most common usage
  • Changes ruleFile and promptFile to sourceFile for uniformity through the codebase
  • Simplifies MCP disconnect logic to use a disabled status
  • Fixes edit block opening wrong thing for mcp servers, rules, and prompts in various situations and unifies logic
  • Fixes inaccurate parts of the init prompt
  • Fixes navigation to settings pages from fatal error
  • Fixes toggle switch click propagation
  • Fixes various bad tailwind classname merging
  • Removes unused Prompts section (was merged into rules)

Summary by cubic

Hide MCP Prompts and Resources in the Config > Tools view when none exist to reduce clutter and keep Tools as the focus. Aligns with CON-4022.

  • New Features
    • Render Prompts only when server.prompts.length > 0.
    • Render Resources only when server.resources.length > 0 or server.resourceTemplates.length > 0.

@RomneyDa RomneyDa requested a review from a team as a code owner September 29, 2025 17:24
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team September 29, 2025 17:24
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 29, 2025
@github-actions
Copy link

github-actions bot commented Sep 29, 2025

✅ Review Complete

⚠️ AI review completed but no review output was generated.

Likely cause: Expired CONTINUE_API_KEY or missing continuedev/review-bot assistant

📋 View workflow logs for details.


Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="gui/src/pages/config/sections/ToolsSection.tsx">

<violation number="1" location="gui/src/pages/config/sections/ToolsSection.tsx:329">
The Prompts resource row is rendered twice because this conditional block is duplicated; users will see duplicate Prompts sections when prompts are present.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@RomneyDa RomneyDa closed this Sep 29, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Sep 29, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2025
@RomneyDa RomneyDa reopened this Sep 29, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Issues and PRs Sep 29, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 29, 2025
@RomneyDa RomneyDa changed the title feat: hide MCP resources and prompts if none feat: rules and MCP fixes and UI updates Sep 30, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 1, 2025
@RomneyDa RomneyDa closed this Oct 1, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 1, 2025
@RomneyDa RomneyDa reopened this Oct 1, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Issues and PRs Oct 1, 2025
@RomneyDa RomneyDa closed this Oct 1, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants