Skip to content

Conversation

@mr-c
Copy link
Member

@mr-c mr-c commented May 31, 2022

found while working with @RenskeW

@mr-c mr-c requested a review from tetron May 31, 2022 10:39
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1674 (909e87e) into main (741f4e5) will decrease coverage by 11.24%.
The diff coverage is 0.00%.

❗ Current head 909e87e differs from pull request most recent head d258967. Consider uploading reports for the commit d258967 to get more accurate results

@@             Coverage Diff             @@
##             main    #1674       +/-   ##
===========================================
- Coverage   83.70%   72.47%   -11.24%     
===========================================
  Files          44       44               
  Lines        8133     8123       -10     
  Branches     2224     2138       -86     
===========================================
- Hits         6808     5887      -921     
- Misses        848     1746      +898     
- Partials      477      490       +13     
Impacted Files Coverage Δ
cwltool/job.py 74.60% <0.00%> (-6.89%) ⬇️

... and 29 files with indirect coverage changes

@mr-c mr-c force-pushed the leave_input_staging_directory branch from abfdd3a to 10430ef Compare June 24, 2022 09:14
@kinow
Copy link
Member

kinow commented Jun 24, 2022

Sorry the delay. Tested with the example 15 from the user guide. Confirmed the directory is not deleted. Everything looking good! 👍 Thanks

image

cwltool --leave-tmpdir linkfile.cwl arguments-job.yml

@ltirrell
Copy link

ltirrell commented Mar 8, 2023

wanted to bump this and see if it could be merged. it really helps with debugging and checking intermediate steps in workflows

@mr-c mr-c enabled auto-merge (squash) March 8, 2023 22:52
@ltirrell
Copy link

sorry for another comment, but is there anything holding this back from being merged?

@kinow
Copy link
Member

kinow commented May 10, 2023

sorry for another comment, but is there anything holding this back from being merged?

I think something changed in the commits after I tested it. CI builds are failing now.

@mr-c mr-c force-pushed the leave_input_staging_directory branch from 909e87e to b062155 Compare May 10, 2023 18:19
@mr-c
Copy link
Member Author

mr-c commented May 10, 2023

GitHub Actions and other things are broken https://www.githubstatus.com/incidents/pr3498h3qkfy

@mr-c mr-c force-pushed the leave_input_staging_directory branch from b062155 to d258967 Compare May 13, 2023 13:30
@mr-c mr-c merged commit e79d1a0 into main May 13, 2023
@mr-c mr-c deleted the leave_input_staging_directory branch May 13, 2023 13:49
@mr-c mr-c mentioned this pull request May 13, 2023
mr-c added a commit to DataBiosphere/toil that referenced this pull request Jun 15, 2023
Highlights:

`--leave-tmpdir` includes the input staging directories by @mr-c in common-workflow-language/cwltool#1674 common-workflow-language/cwltool#1840
use importlib instead of the deprecated pkg_resources by @mr-c in common-workflow-language/cwltool#1844
mr-c added a commit to DataBiosphere/toil that referenced this pull request Jun 15, 2023
Highlights:

`--leave-tmpdir` includes the input staging directories by @mr-c in common-workflow-language/cwltool#1674 common-workflow-language/cwltool#1840
use importlib instead of the deprecated pkg_resources by @mr-c in common-workflow-language/cwltool#1844
mr-c added a commit to DataBiosphere/toil that referenced this pull request Jun 15, 2023
Highlights:

`--leave-tmpdir` includes the input staging directories by @mr-c in common-workflow-language/cwltool#1674 common-workflow-language/cwltool#1840
use importlib instead of the deprecated pkg_resources by @mr-c in common-workflow-language/cwltool#1844
mr-c added a commit to DataBiosphere/toil that referenced this pull request Jun 15, 2023
Highlights:

`--leave-tmpdir` includes the input staging directories by @mr-c in common-workflow-language/cwltool#1674 common-workflow-language/cwltool#1840
use importlib instead of the deprecated pkg_resources by @mr-c in common-workflow-language/cwltool#1844
mr-c added a commit to DataBiosphere/toil that referenced this pull request Jun 16, 2023
Highlights:

`--leave-tmpdir` includes the input staging directories by @mr-c in common-workflow-language/cwltool#1674 common-workflow-language/cwltool#1840
use importlib instead of the deprecated pkg_resources by @mr-c in common-workflow-language/cwltool#1844
mr-c added a commit to DataBiosphere/toil that referenced this pull request Jun 16, 2023
Highlights:

`--leave-tmpdir` includes the input staging directories by @mr-c in common-workflow-language/cwltool#1674 common-workflow-language/cwltool#1840
use importlib instead of the deprecated pkg_resources by @mr-c in common-workflow-language/cwltool#1844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants