Skip to content

Conversation

@mr-c
Copy link
Contributor

@mr-c mr-c commented Jun 15, 2023

Highlights:

Changelog Entry

To be copied to the draft changelog by merger:

  • Upgrade cwltool to verstion 3.1.20230601100705

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passes tests.
  • Make sure the PR has been reviewed since its last modification. If not, review it.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@mr-c mr-c force-pushed the cwltool_3.1.20230601100705 branch 3 times, most recently from 8eb0848 to 17a1495 Compare June 15, 2023 16:03
Highlights:

`--leave-tmpdir` includes the input staging directories by @mr-c in common-workflow-language/cwltool#1674 common-workflow-language/cwltool#1840
use importlib instead of the deprecated pkg_resources by @mr-c in common-workflow-language/cwltool#1844
@mr-c mr-c force-pushed the cwltool_3.1.20230601100705 branch from 17a1495 to 00fb975 Compare June 16, 2023 06:15
@mr-c mr-c merged commit 919a7dc into master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants