GM: Set Panda to Cam Harness safety param when needed #24911
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only needed to prevent a merge conflict...
JMPZ11
force-pushed
the
gm-set-safetymodel
branch
from
f26569b to
cf774b3
Compare
Contributor
|
Looks like this is done in the Bolt port PR. No need to break out this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the CarParam networkLocation is fwdCamera, set the panda safetyparam to FLAG_GM_HW_CAM to enable camera forwarding and support for stock longitudinal
Note: Depends on OP PR #24910 (Add/support CarParams transmissionType...) (added "car." to avoid merge conflict)
Note: Depends on Panda PR commaai/panda/#962 (Support for cam harness...) (references unmerged branch)
Verification
gm-silverado-wip (PR #24875) has been tested on a Silverado and a GMC Sierra and the safetyparam works great!