-
Notifications
You must be signed in to change notification settings - Fork 10.4k
GM: Bolt EUV port #24875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GM: Bolt EUV port #24875
Conversation
|
Let's break this up into individual car ports. I'd recommend just removing one from this PR and making a new PR once we get this new platform merged with a single car. |
Thanks Adeeb, Sounds like a plan - before I do too much splitting (I'm happy to break it down to more easily testable chunks) I wanted to make sure the approach was acceptable. I'll throw PR comments with things about which I have questions - if that's ok |
|
panda and this PR should be ready for final review! |
Co-authored-by: Adeeb Shihadeh <[email protected]>
|
Thanks for the PR @JasonJShuler! |
Basic port for vehicles with ACC, but without an ASCM (or accessible radar points)
Bolt EUV and Silverado have been added; Suburban, Tahoe 2022 Bolt LT2, GMC Sierra (after GM VIN query) are now simple ports.
EDIT: Will break down into parts, but wanted to get the final appearance down and get feedback on some choices.
Depends on two unmerged PRs:
For testing purposes, these PRs have been pre-merged / referenced - This branch builds and passes pre-commit
Includes Silverado and Bolt EUV - tunes both require review
Checklist
selfdrive/car/docs.pyto generate new docs