Skip to content

Conversation

@JMPZ11
Copy link
Contributor

@JMPZ11 JMPZ11 commented Jun 16, 2022

Basic port for vehicles with ACC, but without an ASCM (or accessible radar points)
Bolt EUV and Silverado have been added; Suburban, Tahoe 2022 Bolt LT2, GMC Sierra (after GM VIN query) are now simple ports.

EDIT: Will break down into parts, but wanted to get the final appearance down and get feedback on some choices.

Depends on two unmerged PRs:

For testing purposes, these PRs have been pre-merged / referenced - This branch builds and passes pre-commit

Includes Silverado and Bolt EUV - tunes both require review

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py

@adeebshihadeh adeebshihadeh changed the title Remainder of Cam Harness port GM: Bolt EUV + Silverado ports Jun 16, 2022
@adeebshihadeh
Copy link
Contributor

Let's break this up into individual car ports. I'd recommend just removing one from this PR and making a new PR once we get this new platform merged with a single car.

@JMPZ11
Copy link
Contributor Author

JMPZ11 commented Jun 16, 2022

Let's break this up into individual car ports. I'd recommend just removing one from this PR and making a new PR once we get this new platform merged with a single car.

Thanks Adeeb, Sounds like a plan - before I do too much splitting (I'm happy to break it down to more easily testable chunks) I wanted to make sure the approach was acceptable. I'll throw PR comments with things about which I have questions - if that's ok

@JMPZ11 JMPZ11 force-pushed the gm-silverado-wip branch from 813d562 to 5273f37 Compare June 16, 2022 04:46
@JMPZ11 JMPZ11 force-pushed the gm-silverado-wip branch from 5273f37 to 90394e8 Compare June 16, 2022 04:49
@sshane sshane marked this pull request as ready for review August 12, 2022 07:23
@sshane
Copy link
Contributor

sshane commented Aug 12, 2022

panda and this PR should be ready for final review!

@sshane sshane requested a review from adeebshihadeh August 12, 2022 08:09
Co-authored-by: Adeeb Shihadeh <[email protected]>
@sshane
Copy link
Contributor

sshane commented Aug 12, 2022

Thanks for the PR @JasonJShuler!

@sshane sshane merged commit 4ffe9e6 into commaai:master Aug 12, 2022
@sshane sshane deleted the gm-silverado-wip branch August 12, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants