support upload 3d model to custom subfolder #8597
Merged
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtydhr88
requested review from
yoland68,
robinjhuang,
pythongosssss,
ltdrdata,
Kosinkadink,
webfiltered and
christian-byrne
as code owners
christian-byrne
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Adds subfolder support for 3D model loading using pathlib.rglob(). Implementation looks good.
Testing: Benchmarked rglob("*") with filtering vs other approaches - current implementation is 2-3x faster. Scales well with large directories.
This PR must be merged BEFORE the frontend PR Comfy-Org/ComfyUI_frontend#4209. The frontend is already sending subfolder parameters that require this backend support to function correctly.
rakki194
pushed a commit
to rakki194/ComfyUI
that referenced
this pull request
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BE change for Comfy-Org/ComfyUI_frontend#4209 to support subfolder of 3d folder