[3d] better solution to support reading extra resource/texture #4209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After a period of testing, I found that in order to better implement this texture modification, we still need to support uploading models and their corresponding resources to different folders. Previously, all model files would be uploaded to the '3d' folder, and during the upload process, files with duplicate names would be automatically renamed. As for resource files, they needed to be manually copied to the 3d folder, which created a problem where files with the same names would be overwritten. Therefore, a better approach is to allow users to upload different models and their corresponding resources to different subfolders. This is the change implemented in this PR. 2025-06-20.04-56-34.mp4need BE change comfyanonymous/ComfyUI#8597 |
comfy-jinyi
pushed a commit
that referenced
this pull request
Jul 4, 2025
benceruleanlu
pushed a commit
that referenced
this pull request
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just find out a correct way to handle extra resource/texture reading for 3d model, rather than writting an override class.
Tested on:
OBJ+MTL
GLTF+Extra Texture
FBX+Extra Texture
Resolved #4101
┆Issue is synchronized with this Notion page by Unito