Improve behavior on errors when importing a dataset #74
Conversation
| const data = loadEpidata(title, res, columns, columnRenamings, { _endpoint: endpoint, ...params }); | ||
| if (data.datasets.length == 0) { | ||
| try { | ||
| const data = loadEpidata(title, res, columns, columnRenamings, { _endpoint: endpoint, ...params }); |
There was a problem hiding this comment.
can we put the try block around just this loadEpidata() line? if the other lines are throwing exceptions, we should handle them in a different way.
There was a problem hiding this comment.
I believe this is already the case? The try block is around three lines:
const data = loadEpidata(...)
if (data.datasets.length == 0) {...}
return data;
And the last two can't really error out.
There was a problem hiding this comment.
thats what im saying -- the try scope should contain only the line(s) where we anticipate a possible exception
src/api/EpiData.ts
Outdated
| ` | ||
| <div class="uk-alert uk-alert-error"> | ||
| <a href="${url.href}">API Link</a> returned no data. | ||
| Failed to fetch API data from <a href="${url.href}">API Link</a>. |
There was a problem hiding this comment.
can we add more information to this, like the returned status code at the very least? when a user runs into the rate limiting, this will be helpful. in fact, when a 429 is served via the API, it returns this html in the body, which would be even more useful to a user:
<!doctype html>
<html lang=en>
<title>429 Too Many Requests</title>
<h1>Too Many Requests</h1>
<p>Rate limit exceeded for anonymous queries. To remove this limit, register a free API key at https://api.delphi.cmu.edu/epidata/admin/registration_form</p>There was a problem hiding this comment.
Also fixed - it should now include the error code if it's not inside the JSON.
There was a problem hiding this comment.
this isnt working for me when it encounters a 429 from making too many requests... it still just says "Failed to fetch API data from API Link."
|
Still showing no error detail when rate limit has been exceeded: |
There was a problem hiding this comment.
nice, this shows the error message that accompanies the 429 response now:
a couple things to neaten up and i think this is done... also, should we wait until #83 is fixed before merging?
| return fetch(url.toString(), fetchOptions).then((d) => { | ||
| return processResponse(d); | ||
| }); |
There was a problem hiding this comment.
would this work (or something similar)?
| return fetch(url.toString(), fetchOptions).then((d) => { | |
| return processResponse(d); | |
| }); | |
| return fetch(url.toString(), fetchOptions).then(processResponse); |
src/api/EpiData.ts
Outdated
| .alert( | ||
| ` | ||
| <div class="uk-alert uk-alert-error"> | ||
| Failed to fetch API data from <a href="${url.href}">API Link</a>:<br/><i>${res['message']}</i> |
There was a problem hiding this comment.
can we make the three versions of this message ever-so-slightly different (for ease of future debugging)?
| Failed to fetch API data from <a href="${url.href}">API Link</a>:<br/><i>${res['message']}</i> | |
| Failed to fetch API data from <a href="${url.href}">API Link</a>: (code f01)<br/><i>${res['message']}</i> |
Closes #45.
In the Import Dataset dialogue, displays the errors from the EpiData API to the user if one is present: