- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3
Closed
Labels
Description
A bug appears to have been introduced by #67 where the "last" form values (saved from the previous use of the form) are not updating or being used properly.
To reproduce while varying the geo value:
- open a new epivis session
- open the "Load from Epidata API" dialog, select the "Delphi COVIDcast" data source, and enter the other form values for a valid data series
- observe that the requested series is loaded successfully
- again open the "Load from Epidata API" dialog, and notice the form values have been saved
- change the "Geographic Value" to a different but valid option
- click "FETCH DATA" and observe the error dialog containing the text "Cannot import duplicate dataset:" and also the text of the initial geographic value
- again open the "Load from Epidata API" dialog, notice the form values have been saved, including the second geographic value
- (optionally) change any or all of the form values
- click "FETCH DATA" and observe the successful loading of the data series previously selected, with the second geographic value (and other prior form choices)
Note that this bug can also be triggered, for instance, by changing the "Data Signal" instead of the "Geographic Value" (along with any of the other fields as well)
The following are NOT affected:
- current live version 2.1.5 at https://delphi.cmu.edu/epivis/
- (from Release v2.1.5 #81)
 
- netlify preview at https://deploy-preview-72--cmu-delphi-epivis.netlify.app/
- (from Add persistence to API keys #72, which was merged into devafter Release v2.1.5 but before Add persistence to API import forms #67)
 
- (from Add persistence to API keys #72, which was merged into 
The following are affected:
- netlify preview at https://deploy-preview-67--cmu-delphi-epivis.netlify.app/
- (from Add persistence to API import forms #67, which appears to be the source of these)
 
- netlify preview at https://dev--cmu-delphi-epivis.netlify.app/
- (which is based on the current devbranch, and Add persistence to API import forms #67 was the most recent merge intodev)
 
- (which is based on the current 
- netlify preview at https://deploy-preview-74--cmu-delphi-epivis.netlify.app/
- (from Improve behavior on errors when importing a dataset #74, which is based on devafter Add persistence to API import forms #67 was merged into it)
 
- (from Improve behavior on errors when importing a dataset #74, which is based on 
- netlify preview at https://cmu-delphi-epivis.netlify.app/
- (which is SUPPOSED to be based on the current mainbranch (at least according to), but i think it is actually from theLine 11 in f9a3a19 The next `dev` version is deployed at https://dev--cmu-delphi-epivis.netlify.app/. devbranch because it is displaying the functionality from Add persistence to API keys #72 and Add persistence to API import forms #67 instead of behaving like the current live production version)
- (we can ignore this one for now, but someone should eventually figure out why it does not reflect what it claims to)
 
- (which is SUPPOSED to be based on the current