Release Delphi Epidata 0.4.0 #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update workflow to build container images from branch
a few notes: composite key definitions could be made part of Database class. i used the variable name "ell" because the single lowercase letter "l" looks ambiguous. could do away with update_latest column and just use "WHERE d.delete_latest_id<>NULL" instead of "WHERE d.update_latest=1". could do away with delete_latest_id column if we assume signal_data_id's are synced properly between latest+history tables.
….. and also restore a method that got deleted??
…nd of regular acquisition method, removed helper to run dbjobs as a standalone process
Co-authored-by: Andrew Chin <[email protected]>
Co-authored-by: Katie Mazaitis <[email protected]>
Co-authored-by: Katie Mazaitis <[email protected]>
…rep-prep V4 schema revisions candidate
they come from a pending changeset to incorporate (into this branch, 'v4-srrpp-migrations') improvements made in a parallel 'mergedkey' branch... i fear i may just be kicking more merge conflicts down the road, but hopefully this helps me to be less confused about some current diffs in the meantime. changes are: - signal_latest table definition simplified to automatically inherit structure from signal_history table - removal of unused row-counting methods - docstring update / correction
updated Dockerfile to let pip account for all version constraints simultaneously (previous non-simultaneous (ie, sequential) requirements installation resulted in a version conflict on `greenlets` package, see: tiangolo/meinheld-gunicorn-docker#22 ). also bumped python version in that Dockerfile to 3.8 to match python versions elsewhere in the codebase. *note: this fix also requires a change to version pinning in a requirements.txt of the operations branch (see: https://github.com/cmu-delphi/operations/blob/v4-schema-revisions-release-prep-flaskalchemy/dev/docker/python/assets/requirements.txt )
…ternal specification) because they fundamentally change behaviors
…e and deletion of this branch
…rep-flaskalchemy Build and image with new Flask and SQLAlchemy
…ternal specification) because they fundamentally change behaviors
2. format the tables which have < 150 chars per row after formation, to make code more readable for all editors
2. link the list of location labels to the added file in ecdc page
Leonlu2/kcdc
revert ci config change
Fix Makefile grep command and package-lock.json
Fix repo pointers in package.json and package-lock.json
melange396
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
i think this is good to go, but i have two concerns:
- it includes the changes to
package-lock.jsonthat i am not sure of the reasons for or ramifications of.
and, semi-relatedly:
- the version number for this release was bumped from
0.3.21to0.4.0insrc/client/packaging/npm/package.json, but the associatedsrc/client/packaging/npm/package-lock.jsonstill has version0.3.14. Since the last release has been living with this, i am going to presume its not a showstopper, but i will file an issue about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing Delphi Epidata 0.4.0.