Skip to content

Fix Makefile grep command and package-lock.json #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2022
Merged

Fix Makefile grep command and package-lock.json #979

merged 2 commits into from
Sep 23, 2022

Conversation

@dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Sep 22, 2022 •
edited
Loading

closes

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Because we updated MYSQL version, the line we search in the logs to detect that the DB is ready has changed. So change it in the Makefile here.

@dshemetov dshemetov requested a review from rzats September 22, 2022 22:24
rzats
rzats previously approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@rzats rzats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it does fix make all & make test. LGTM!

@dshemetov dshemetov changed the title Fix Makefile grep command Fix Makefile grep command and package-lock.json Sep 23, 2022
@dshemetov dshemetov requested a review from rzats September 23, 2022 05:29
@krivard krivard merged commit a9e9d1a into dev Sep 23, 2022
@krivard krivard deleted the ds/fix-makefile branch September 23, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rzats rzats rzats approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dshemetov @rzats @krivard