Skip to content

fix: handle cornercases where source is not transmitted for aliases #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix: handle cornercases where source is not transmitted for aliases #661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/server/endpoints/covidcast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,10 @@ def handle():

_handle_lag_issues_as_of(q, issues, lag, as_of)

def transform_row(row, _):
if is_compatibility or not alias_mapper:
def transform_row(row, proxy):
if is_compatibility or not alias_mapper or 'source' not in row:
return row
row["source"] = alias_mapper(row["source"], row["signal"])
row["source"] = alias_mapper(row["source"], proxy["signal"])
return row

# send query
Expand Down Expand Up @@ -608,10 +608,10 @@ def handle_coverage():

_handle_lag_issues_as_of(q, None, None, None)

def transform_row(row, _):
if not alias_mapper:
def transform_row(row, proxy):
if not alias_mapper or 'source' not in row:
return row
row["source"] = alias_mapper(row["source"], row["signal"])
row["source"] = alias_mapper(row["source"], proxy["signal"])
return row

return execute_query(q.query, q.params, fields_string, fields_int, [], transform=transform_row)
Expand Down