Skip to content

fix: handle cornercases where source is not transmitted for aliases #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix: handle cornercases where source is not transmitted for aliases #661

merged 1 commit into from
Jul 28, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Jul 28, 2021

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

fix a cornercases in the alias resolver which didn't consider when the source is not about to be returned

@sgratzl sgratzl added the bug label Jul 28, 2021
@sgratzl sgratzl requested a review from krivard July 28, 2021 15:16
@sgratzl sgratzl self-assigned this Jul 28, 2021
krivard
krivard approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very tidy

@sgratzl sgratzl merged commit fd96964 into dev Jul 28, 2021
@sgratzl sgratzl deleted the sgratzl/alias_fix branch July 28, 2021 19:34
@krivard krivard mentioned this pull request Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krivard krivard krivard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sgratzl sgratzl

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sgratzl @krivard