Add GitHub workflow to check for PRs with merge-blocking labels #862
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: Check merge labels | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [labeled, unlabeled] | ||
| merge_group: | ||
| permissions: read-all | ||
|
|
||
| jobs: | ||
| label_checks: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - id: explicitly_disallowed | ||
| if: | | ||
| contains(github.event.pull_request.labels.*.name, 'do not merge') | ||
| run: | | ||
| echo "This is labeled \"Do not merge\"." | ||
| exit 1 | ||
|
|
||
| - id: future_release | ||
| if: | | ||
| contains(github.event.pull_request.labels.*.name, 'release-0.9') | ||
| run: | | ||
| echo "This is targeted for a future release." | ||
| exit 1 | ||
|
|
||
| - id: breaking_change | ||
| if: | | ||
| contains(github.event.pull_request.labels.*.name, 'abi-break') || | ||
| contains(github.event.pull_request.labels.*.name, 'breaking change') | ||
| run: | | ||
| echo "This is a breaking change." | ||
| exit 1 | ||
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this always be
spacetimedb-runner?It seemed like that always forced the jobs onto a queue, even for these
runs that don't require anything fancy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, generally the
spacetimedb-runneris going to be much faster compared to the regular github ubuntu-latest runner, but for things like this its fine to just use the github runner.