Add GitHub workflow to check for PRs with merge-blocking labels #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
added
abi-break
bfops
added
release-0.9
and removed
bug
bfops
added
release-any
bfops
commented
Feb 16, 2024
| contains(github.event.pull_request.labels.*.name, 'breaking change') | ||
| run: | | ||
| echo "This is a breaking change." | ||
| exit 1 |
There was a problem hiding this comment.
I made these all steps instead of e.g. different jobs because it cluttered up the list of checks in the PR view, but I don't feel strongly about it if there's a better organization.
bfops
commented
Feb 16, 2024
|
|
||
| jobs: | ||
| label_checks: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
should this always be spacetimedb-runner?
It seemed like that always forced the jobs onto a queue, even for these runs that don't require anything fancy.
There was a problem hiding this comment.
Yeah, generally the spacetimedb-runner is going to be much faster compared to the regular github ubuntu-latest runner, but for things like this its fine to just use the github runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added a GitHub workflow to check for PRs with a
Do not mergelabel, for ad-hoc PR blocking.Note: A repo admin must make this a merge-blocking check!
API and ABI breaking changes
No runtime changes.
Expected complexity level and risk
1