-
Notifications
You must be signed in to change notification settings - Fork 646
feat(748): Add compile time feature flag for table metrics #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Centril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw more with_label_values in:
database_intance_context_controlcommit_logrelational_dblocking_tx_datastore/mod.rswasm_intance_envquerysubscription
|
@Centril these were the only ones I saw in the profile, apart from query duration metrics. I didn't want to remove all of them, since @jdetter probably still wants at least some observability when perf testing. These ones will remove the added latency to reducer calls. I can also put the query duration metrics behind the flag, but perhaps @jdetter should weigh in if he thinks they're still important for perf testing. |
I'd suggest two gates in that case, one with the ones in this PR and one with the rest. |
|
I'm watching this one closely, if we can cover as many metrics as possible with the temporary |
Closes #748. This patch adds a temporary feature flag for enabling db metrics. Metrics are recorded synchronously at the moment. This can have a noticable impact on latency. Compiling with this flag will enable metrics collection. This new flag will be turned on by default. Hence metrics will be collected by default. Note this flag is temporary. It will be removed once metrics are recorded async.
53e776f to
ee5339a
Compare
jdetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, this looks great Josh. I'll include this in the benchmark this weekend 👍
Incorporated Centril's suggestions
A call site for record_query_duration_metrics was missed in #749.
A call site for record_query_duration_metrics was missed in #749.
Closes #748.
This patch adds a temporary feature flag for enabling table metrics.
Table metrics are potentially recorded many times within a transaction. This recording is synchronous and therefore can have a noticable impact on latency.
This new flag will be enabled by default.
With it, table metrics will be recorded; without it, they won't.
Note this flag is temporary.
It will be removed once metrics are recorded async.
Description of Changes
Please describe your change, mention any related tickets, and so on here.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.