Add Hash for RowRef + make it consistent with Hash for PV
#1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Make `RowRef::row_hash` use the above. 3. Make `Table::insert` return a `RowRef`. 4. Use less unsafe because of 1-3. 5. Use `second-stack` to reuse temporary allocations in hashing and serialization.
Centril
force-pushed
the
centril/row-ref-hash
branch
from
5ac6720 to
0e8f83c
Compare
gefjon
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Hash for RowRef+ make it consistent withHash for ProductValue.RowRef::row_hashuse the above.Table::insertreturn aRowRef.second-stackto reuse temporary allocations in hashing and serialization.Fixes #1107.
API and ABI breaking changes
None
Expected complexity level and risk
3, some unsafe involved and we need to ensure consistency in the eq/hash functions.
Some unsafe code is also removed.
Testing
Proptests are added for the new code.