Skip to content

Conversation

@rktguswjd
Copy link
Contributor

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

None

Summary

  • Tooltipcontainer 속성을 제거합니다.
  • TooltipcontentWrapperStyle 속성을 추가합니다.

Details

  • 외부 container 속성을 지정했을 때 해당 노드 아래에 렌더되도록 할 수 있게 수정하였으나 Tooltip의 로직은 container를 고려해 작성이 되지 않았습니다.
  • 따라서 별도의 contentWrapperStyle 속성을 지정하여 필요에 따라 zIndex 등의 스타일을 설정할 수 있게 수정합니다. (이는 임시방편이며 현재 새로운 Tooltip 컴포넌트를 재구현중에 있습니다.)

Breaking change or not (Yes/No)

References

@rktguswjd rktguswjd requested a review from sungik-choi as a code owner April 19, 2023 04:34
@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

🦋 Changeset detected

Latest commit: 511aa6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rktguswjd rktguswjd self-assigned this Apr 19, 2023
@rktguswjd rktguswjd added the enhancement Issues or PR related to making existing features better label Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.02 🎉

Comparison is base (c778a92) 78.16% compared to head (511aa6c) 78.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           next-v1    #1292      +/-   ##
===========================================
+ Coverage    78.16%   78.18%   +0.02%     
===========================================
  Files          294      294              
  Lines         3796     3796              
  Branches       839      838       -1     
===========================================
+ Hits          2967     2968       +1     
  Misses         545      545              
+ Partials       284      283       -1     
Impacted Files Coverage Δ
...es/bezier-react/src/components/Tooltip/Tooltip.tsx 73.46% <ø> (ø)
...zier-react/src/components/Tooltip/Tooltip.types.ts 100.00% <ø> (ø)
...kages/bezier-react/src/components/Tooltip/utils.ts 32.05% <66.66%> (+2.18%) ⬆️
...er-react/src/components/Tooltip/TooltipContent.tsx 81.25% <100.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues or PR related to making existing features better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants