feat(tooltip): add container prop #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungik-choi
added
the
enhancement
🦋 Changeset detectedLatest commit: 54bfa00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Chromatic Report🚀 Congratulations! Your build was successful! |
sungik-choi
force-pushed
the
feat/tooltip-container
branch
from
463c68c to
54bfa00
Compare
sungik-choi
commented
Mar 30, 2023
Comment on lines
-85
to
-94
| const [showTarget, setShowTarget] = useState(true) | ||
|
|
||
| const handleClick = useCallback(() => { | ||
| setShowTarget(false) | ||
| }, []) | ||
| const [container, setContainer] = useState<HTMLDivElement | null>(null) | ||
|
|
||
| return ( | ||
| <Tooltip {...props}> | ||
| { showTarget && ( | ||
| <Target onClick={handleClick}> |
Contributor
Author
There was a problem hiding this comment.
적절하지 않은 스토리라고 판단하여 간단명료한 스토리로 변경
rktguswjd
approved these changes
Mar 31, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
CODEOWNERSfile.Related Issue
None
Summary
Tooltip에container속성을 추가합니다.Details
Overlay와 동일하게, 별도의container속성을 지정하면 해당 노드 아래에 렌더되도록 할 수 있습니다.Breaking change or not (Yes/No)
No. container를 지정하지 않을 경우 기본값은
getRootElement()의 반환값으로 동일합니다.References
None