-
Notifications
You must be signed in to change notification settings - Fork 52
Add new palette & text specs #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leejiwoo2002
merged 5 commits into
channel-io:next-v1
from
leejiwoo2002:feat/add-new-specs
Mar 24, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
75cd93e
feat: add new Pallete & background colors
leejiwoo2002 e22287b
feat: add new text specs
leejiwoo2002 58b5895
chore: add changeset
leejiwoo2002 1d94afe
fix: lint typo error
leejiwoo2002 20c37af
docs: add more details on changeset
leejiwoo2002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| "@channel.io/bezier-react": patch | ||
| --- | ||
|
|
||
| add new text/palette specs | ||
| - add 2 color palette | ||
| - grey50_80 | ||
| - grey850_80 | ||
| - add 2 text specs | ||
| - size30 | ||
| - size36 | ||
| - add 3 semantic colors | ||
| - bg-grey-dim-lightest | ||
| - light: grey50_80 | ||
| - dark: grey850_80 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,9 @@ type MonoBackgroundColor = | |
| | `bg-${BaseMonoPaletteKey}-light` | ||
| | `bg-${BaseMonoPaletteKey}-lighter` | ||
| | `bg-${BaseMonoPaletteKey}-lightest` | ||
| | `bg-${BasePaletteKey.Grey}-dim-lightest` | ||
| | `bg-${BasePaletteKey.White}-dim-dark` | ||
| | `bg-${BasePaletteKey.White}-dim-light` | ||
|
Comment on lines
+11
to
+13
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. BaseMonoPaletteKey를 쓰기엔 아직 커버하지 못하는 색상들이 있어서 우선 별개로 작성해두었습니다 |
||
|
|
||
| type LayoutBackgroundColor = | ||
| | 'bg-gnb' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경사항에 대해 더 자세히 적어주시면 좋을 거 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR의 내용을 일부 추가하도록 하겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
디테일들 추가했습니다!