-
Notifications
You must be signed in to change notification settings - Fork 52
Add new palette & text specs #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new palette & text specs #1228
Conversation
🦋 Changeset detectedLatest commit: 20c37af The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chromatic Report🚀 Congratulations! Your build was successful! |
b2ea4c4 to
58b5895
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1228 +/- ##
===========================================
+ Coverage 77.88% 77.89% +0.01%
===========================================
Files 295 295
Lines 3784 3786 +2
Branches 836 836
===========================================
+ Hits 2947 2949 +2
Misses 552 552
Partials 285 285
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| | `bg-${BasePaletteKey.Grey}-dim-lightest` | ||
| | `bg-${BasePaletteKey.White}-dim-dark` | ||
| | `bg-${BasePaletteKey.White}-dim-light` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BaseMonoPaletteKey를 쓰기엔 아직 커버하지 못하는 색상들이 있어서 우선 별개로 작성해두었습니다
| "@channel.io/bezier-react": patch | ||
| --- | ||
|
|
||
| add new text/palette specs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경사항에 대해 더 자세히 적어주시면 좋을 거 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR의 내용을 일부 추가하도록 하겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
디테일들 추가했습니다!
Self Checklist
CODEOWNERSfile.Summary
add new foundation specs for meet feature
Details
add 2 color palette
add 2 text specs
add 3 semantic colors
Breaking change or not (Yes/No)
No
References
desk thread
figma