Skip to content

Conversation

@leejiwoo2002
Copy link
Contributor

@leejiwoo2002 leejiwoo2002 commented Mar 23, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Summary

add new foundation specs for meet feature

Details

add 2 color palette

  • grey50_80
  • grey850_80

add 2 text specs

  • size30
  • size36

add 3 semantic colors

  • bg-grey-dim-lightest
  • light: grey50_80
  • dark: grey850_80

Breaking change or not (Yes/No)

No

References

desk thread
figma

@leejiwoo2002 leejiwoo2002 added the feat:foundation Issue of PR related to a new foundation label Mar 23, 2023
@leejiwoo2002 leejiwoo2002 self-assigned this Mar 23, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2023

🦋 Changeset detected

Latest commit: 20c37af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

Chromatic Report

🚀 Congratulations! Your build was successful!

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (f46218e) 77.88% compared to head (20c37af) 77.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           next-v1    #1228      +/-   ##
===========================================
+ Coverage    77.88%   77.89%   +0.01%     
===========================================
  Files          295      295              
  Lines         3784     3786       +2     
  Branches       836      836              
===========================================
+ Hits          2947     2949       +2     
  Misses         552      552              
  Partials       285      285              
Impacted Files Coverage Δ
...ezier-react/src/foundation/Colors/Palette/index.ts 100.00% <ø> (ø)
...t/src/foundation/Colors/Theme/presets/DarkTheme.ts 100.00% <ø> (ø)
.../src/foundation/Colors/Theme/presets/LightTheme.ts 100.00% <ø> (ø)
packages/bezier-react/src/foundation/Typography.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines +11 to +13
| `bg-${BasePaletteKey.Grey}-dim-lightest`
| `bg-${BasePaletteKey.White}-dim-dark`
| `bg-${BasePaletteKey.White}-dim-light`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseMonoPaletteKey를 쓰기엔 아직 커버하지 못하는 색상들이 있어서 우선 별개로 작성해두었습니다

"@channel.io/bezier-react": patch
---

add new text/palette specs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항에 대해 더 자세히 적어주시면 좋을 거 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR의 내용을 일부 추가하도록 하겠습니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디테일들 추가했습니다!

@sungik-choi sungik-choi added the design update Issue or PR that Up-to-date specifications for design system updates label Mar 23, 2023
@leejiwoo2002 leejiwoo2002 merged commit c68bec8 into channel-io:next-v1 Mar 24, 2023
@leejiwoo2002 leejiwoo2002 deleted the feat/add-new-specs branch March 24, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design update Issue or PR that Up-to-date specifications for design system updates feat:foundation Issue of PR related to a new foundation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants