Solari BLAS compaction #20457
Open
Solari BLAS compaction #20457
+73
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMS55
added
A-Rendering
JMS55
requested review from
Elabajaba,
IceSentry,
atlv24,
SparkyPotato and
tychedelia
JMS55
added
the
S-Needs-Review
SparkyPotato
reviewed
Aug 8, 2025
|
|
||
| /// After compacting this many vertices worth of meshes per frame, no further BLAS will be compacted. | ||
| /// Lower this number to distribute the work across more frames. | ||
| const MAX_COMPACTION_VERTICES_PER_FRAME: u32 = 400_000; |
There was a problem hiding this comment.
Could this be a plugin setting or resource?
There was a problem hiding this comment.
Eventually yes, for now nothing in solari is configurable. It's in the tracking issue.
SparkyPotato
approved these changes
Aug 8, 2025
atlv24
reviewed
Aug 8, 2025
| blas_manager.compaction_queue.pop_front() | ||
| { | ||
| // Stop iterating once we loop back around to the start of the list | ||
| if Some(mesh) == first_mesh_processed { |
There was a problem hiding this comment.
if everything is already maximally compacted, this will iterate all entities every frame right?
There was a problem hiding this comment.
Once something is compacted, it stops getting added back to the compaction queue. So the list would be empty.
atlv24
approved these changes
Aug 8, 2025
JMS55
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No compaction:
Compaction:
