Add winit phase to MouseWheel event #20438
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
force-pushed
the
mousewheel-phase
branch
from
2b11f90 to
58bb0eb
Compare
liamaharon
force-pushed
the
mousewheel-phase
branch
from
58bb0eb to
1255c99
Compare
Zeophlite
approved these changes
Aug 6, 2025
kristoff3r
approved these changes
Aug 6, 2025
liamaharon
commented
Aug 7, 2025
| @@ -127,11 +127,14 @@ pub enum ForceTouch { | |||
| reflect(Serialize, Deserialize) | |||
| )] | |||
| pub enum TouchPhase { | |||
There was a problem hiding this comment.
One thing that feels weird to me is using the TouchPhase from touch.rs in mouse.rs. Open to suggestions if this is a concern.
|
Converting this to a draft - I was finally able to test with a physical mouse, and its wheel scroll events sadly also emit touch phase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow detecting whether MouseWheel events originate from a mouse scroll wheel or trackpad.
See johanhelsing/bevy_pancam#81 (comment) for use case.
Solution
Propagate the
TouchPhasefromwinit, which allows distinguishing mouse wheel scroll from touchpad scroll: rust-windowing/winit#4315 (comment)Testing
I'm currently only able to test on a MacOS, it would be great if I could get help testing with a mouse and also a Windows & Linux trackpad.