-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Closed
3 / 33 of 3 issues completed
Copy link
Labels
A-Build-SystemRelated to build systems or continuous integrationRelated to build systems or continuous integrationC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or changeC-Tracking-IssueAn issue that collects information about a broad development initiativeAn issue that collects information about a broad development initiativeD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examples
Description
The benchmarks and compile_fail UI tests are currently excluded from the main Cargo workspace:
Lines 16 to 22 in 00722b8
| exclude = [ | |
| "benches", | |
| "crates/bevy_derive/compile_fail", | |
| "crates/bevy_ecs/compile_fail", | |
| "crates/bevy_reflect/compile_fail", | |
| "tools/compile_fail_utils", | |
| ] |
This is a problem because these things get checked less often, and often lag behind. For example, in #16733 I had to fix a compile error for a function that was removed in 0.10 (we just released 0.15). The best solution to prevent this from happening in the future is to re-add the benchmarks and UI tests to the main Cargo workspace.
Past attempt: #16770
Sub-issues
Metadata
Metadata
Assignees
Labels
A-Build-SystemRelated to build systems or continuous integrationRelated to build systems or continuous integrationC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or changeC-Tracking-IssueAn issue that collects information about a broad development initiativeAn issue that collects information about a broad development initiativeD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examples